Subject: Re: Unix-domain socket support on Windows
To: "Hamlin, Garick L" <ghamlin@isc.upenn.edu>
References: <54bde68c-d134-4eb8-5bd3-8af33b72a010@2ndquadrant.com>
 <00d4945e-b437-f3b5-f4af-42e99321c846@2ndquadrant.com>
 <CA+hUKGLkUTNjRZC9e4XjvLQCXL9Dre5ZQhoPqN+rZWbGYV1BQA@mail.gmail.com>
 <fe46da42-00f0-ef1f-ab52-456df58b5bff@2ndquadrant.com>
 <5974caea-1267-7708-40f2-6009a9d653b0@2ndquadrant.com>
 <CAA8=A7-VsWR9Z8Dg0XWTreP_x5=u2cXpGgJymy8-_yesEpHMFg@mail.gmail.com>
 <ce26e70c-cfa6-2f47-5c33-f88bc4d4f288@2ndquadrant.com>
 <75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com>
 <20191218142419.fvv4ikm4wq4gnkco@isc.upenn.edu>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <5231fafe-bda0-5a4d-d75b-c83d96ee5758@2ndquadrant.com>
Date: Wed, 18 Dec 2019 17:03:40 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20191218142419.fvv4ikm4wq4gnkco@isc.upenn.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-12-18 15:24, Hamlin, Garick L wrote:
> On Wed, Dec 18, 2019 at 02:52:15PM +0100, Peter Eisentraut wrote:
>> To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR
>> to "" has the desired effect.  This mostly already worked like that;
>> only a few places needed to be adjusted.  Notably, the reference to
>> DEFAULT_PGSOCKET_DIR in UNIXSOCK_PATH() could be removed because all
>> callers already resolve an empty socket directory setting with a
>> default if appropriate.
> 
> Would it make sense to support abstract sockets in PostgreSQL?

Maybe, I'm not sure.

> I know it's bit unrelated.  I haven't read all the code here I just was
> thinking about it because of the code checking the leading \0 byte of the dir.

We would probably represent abstract sockets with a leading '@' in the 
user-facing components and only translate it to the internal format at 
the last moment, probably in that very same UNIXSOCK_PATH() function. 
So I think that wouldn't be a problem.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services