Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qc3P2-00DhYE-Hz
	for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Sep 2023 12:37:32 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qc3P1-00EK6S-4g
	for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Sep 2023 12:37:30 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qc3P0-00EK6G-QC
	for pgsql-hackers@lists.postgresql.org; Fri, 01 Sep 2023 12:37:30 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qc3Ox-0029ZX-Kb
	for pgsql-hackers@postgresql.org; Fri, 01 Sep 2023 12:37:29 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 381CbHnm523732;
	Fri, 1 Sep 2023 08:37:17 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Krishnakumar R <kksrcv001@gmail.com>
cc: pgsql-hackers@postgresql.org, "andres@anarazel.de" <andres@anarazel.de>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Move bki file pre-processing from initdb to bootstrap
In-reply-to: <CAPMWgZ9TCByVjpfdsgyte4rx=YsrAttYay2xDK4UN4Lm=-wJMQ@mail.gmail.com>
References: <CAPMWgZ9TCByVjpfdsgyte4rx=YsrAttYay2xDK4UN4Lm=-wJMQ@mail.gmail.com>
Comments: In-reply-to Krishnakumar R <kksrcv001@gmail.com>
	message dated "Fri, 01 Sep 2023 01:01:31 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <523730.1693571837.1@sss.pgh.pa.us>
Date: Fri, 01 Sep 2023 08:37:17 -0400
Message-ID: <523731.1693571837@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/523731.1693571837%40sss.pgh.pa.us>
Precedence: bulk

Krishnakumar R <kksrcv001@gmail.com> writes:
> This patch moves the pre-processing for tokens in the bki file from
> initdb to bootstrap. With these changes the bki file will only be
> opened once in bootstrap and parsing will be done by the bootstrap
> parser.

You haven't provided any iota of evidence why this would be an
improvement.

			regards, tom lane