Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M234389=pgsql-hackers-arkari@postgresql.org>)
 id 1VOp3L-0004Aa-U0
 for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Sep 2013 13:22:52 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M234389=pgsql-hackers-arkari@postgresql.org>)
 id 1VOp3L-0005Do-8W
 for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Sep 2013 13:22:51 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <peter_e@gmx.net>) id 1VOp3J-0005Dc-NX
 for pgsql-hackers@postgresql.org; Wed, 25 Sep 2013 13:22:49 +0000
Received: from eisentraut.org ([85.214.91.16] helo=gattler.pezone.net)
 by magus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <peter_e@gmx.net>) id 1VOp3E-0000ZI-7W
 for pgsql-hackers@postgresql.org; Wed, 25 Sep 2013 13:22:49 +0000
Received: from jesse.mybdev.com (unknown [204.145.120.11])
 by gattler.pezone.net (Postfix) with ESMTPSA id 4A45A59000F;
 Wed, 25 Sep 2013 13:22:41 +0000 (UTC)
Message-ID: <5242E39E.20604@gmx.net>
Date: Wed, 25 Sep 2013 09:22:38 -0400
From: Peter Eisentraut <peter_e@gmx.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Alexander Korotkov <aekorotkov@gmail.com>
CC: Heikki Linnakangas <hlinnakangas@vmware.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GIN improvements part 1: additional information
References: 
 <CAPpHfduxv-iL7aedwPW0W5fXrWGAKfxijWM63_hZujaCRxnmFQ@mail.gmail.com>
 <CAPpHfduQrtC4B+MC9_z3QB8oJsK1Ws-H8ivEsy_cmDnfoJqkeQ@mail.gmail.com>
 <CAPpHfdszEJhSynTPX6=tB3aKq1EA1JXpwx4xiFYM097K7PhQLA@mail.gmail.com>
 <CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
 <51CEA13C.8040103@vmware.com>
 <CAPpHfdutJEC9+6vWX579afZKzdHKCT2wzDkAEom1XmiXEwF3pw@mail.gmail.com>
 <5236B6A2.8080607@vmware.com>
 <CAPpHfduiTGZ+xGUPYXjckYVe2cuqx7SVaTsvjVJq5j0ywx6-NQ@mail.gmail.com>
 <CAPpHfdvHZXDGNoGvi9qFQcXQnx_e3u9Rkumtx8gTwpx_EhF6JA@mail.gmail.com>
 <CAPpHfdvbmTrnPg2f6S_E2k2JVmHFipSJPG_ooDHKFbwi4oKfOw@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdvbmTrnPg2f6S_E2k2JVmHFipSJPG_ooDHKFbwi4oKfOw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 9/23/13 5:36 PM, Alexander Korotkov wrote:
> In the attached version of patch double finding of ItemPointer during
> insert is avoided. Overhead becomes lower as expected.

Fails cpluspluscheck:

./src/include/access/gin_private.h: In function ‘char*
ginDataPageLeafReadItemPointer(char*, ItemPointer)’:
./src/include/access/gin_private.h:797:2: warning: comparison between
signed and unsigned integer expressions [-Wsign-compare]



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers