From: Antonin Houska <ah@cybertec.at>
To: Andres Freund <andres@anarazel.de>
cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org,
    Thomas Munro <thomas.munro@gmail.com>,
    Heikki Linnakangas <hlinnaka@iki.fi>,
    Robert Haas <robertmhaas@gmail.com>,
    Jakub Wartak <jakub.wartak@enterprisedb.com>,
    Jelte Fennema-Nio <postgres@jeltef.nl>
Subject: Re: AIO v2.5
In-reply-to: <3yxd5r23zly5bytvgyktbxtxq2r3gbpi7xd4dugevh3h4w4q6c@lu6oatjjpltz>
References: <uvrtrknj4kdytuboidbhwclo4gxhswwcpgadptsjvjqcluzmah@brqs62irg4dt>
 <clt7rl56kxjcnjtqd7fsajkst232c3yh57ggtmppwp5hmtl4os@i3iibeftfrsp>
 <vz5i2x2wkjjpp6l2z4g4l3umpxktrxsejgdwefi7n6kzw666h3@rnhlvlpadig7>
 <ge6nsuddurhpmll3xj22vucvqwp4agqz6ndtcf2mhyeydzarst@l75dman5x53p>
 <20250311194108.c5.nmisch@google.com>
 <5dzyoduxlvfg55oqtjyjehez5uoq6hnwgzor4kkybkfdgkj7ag@rbi4gsmzaczk>
 <20250312035743.f5.nmisch@google.com>
 <w6uiicyou7hzq47mbyejubtcyb2rngkkf45fk4q7inue5kfbeo@bbfad3qyubvs>
 <4b3f32ug3cayekysqlgspz2qjmeb7lca3gvazayglxr2m3d4dv@il33accgsji7>
 <17906.1741863183@localhost>
 <3yxd5r23zly5bytvgyktbxtxq2r3gbpi7xd4dugevh3h4w4q6c@lu6oatjjpltz>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
   message dated "Fri, 14 Mar 2025 15:43:15 -0400."
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Mon, 30 Jun 2025 08:58:21 +0200
Message-ID: <5250.1751266701@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/5250.1751266701%40localhost>
Precedence: bulk

--=-=-=
Content-Type: text/plain

Andres Freund <andres@anarazel.de> wrote:

> On 2025-03-13 11:53:03 +0100, Antonin Houska wrote:
> > Attached are a few proposals for minor comment fixes.
> 
> Thanks, applied.

After reading the code a bit more, I noticed that the 'cb_flags' argument of
PgAioHandleCallbackStage is not really used, at least in the existing
callbacks. Is there an intention to use it in the future (the patches for
async write do not seem to indicate so), or is this only a leftover from
previous versions of the patch?

Besides that, I suggest a minor comment fix.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=comment.diff

diff --git a/src/include/storage/aio_types.h b/src/include/storage/aio_types.h
index 18183366077..afee85c787b 100644
--- a/src/include/storage/aio_types.h
+++ b/src/include/storage/aio_types.h
@@ -107,7 +107,7 @@ typedef struct PgAioResult
 	/* of type PgAioResultStatus, see above */
 	uint32		status:PGAIO_RESULT_STATUS_BITS;
 
-	/* meaning defined by callback->error */
+	/* meaning defined by callback->report */
 	uint32		error_data:PGAIO_RESULT_ERROR_BITS;
 
 	int32		result;

--=-=-=--