Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VTXtx-0002YF-N4 for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Oct 2013 14:04:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1VTXtw-0007Km-Rq for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Oct 2013 14:04:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VTXtu-0007Kb-KI for pgsql-hackers@postgresql.org; Tue, 08 Oct 2013 14:04:38 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:c:538::197]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VTXtq-0008Ty-1x for pgsql-hackers@postgresql.org; Tue, 08 Oct 2013 14:04:37 +0000 Received: from mfilter11-d.gandi.net (mfilter11-d.gandi.net [217.70.178.131]) by relay5-d.mail.gandi.net (Postfix) with ESMTP id 2257541C062; Tue, 8 Oct 2013 16:04:33 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter11-d.gandi.net Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by mfilter11-d.gandi.net (mfilter11-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id haLko9OIPJd6; Tue, 8 Oct 2013 16:04:31 +0200 (CEST) X-Originating-IP: 98.27.58.255 Received: from [192.168.10.146] (cpe-098-027-058-255.nc.res.rr.com [98.27.58.255]) (Authenticated sender: adsend@dunslane.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0EB9941C07E; Tue, 8 Oct 2013 16:04:29 +0200 (CEST) Message-ID: <525410EC.9010002@dunslane.net> Date: Tue, 08 Oct 2013 10:04:28 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Peter Eisentraut CC: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org, Josh Berkus , Robert Haas , Craig Ringer Subject: Re: Bugfix and new feature for PGXS References: <201306181552.36673.cedric@2ndquadrant.com> <51DB171F.2090108@dunslane.net> <201307122350.23726.cedric@2ndquadrant.com> <1739933.FyLmpy7Q73@obelix> <5248B32E.1090001@dunslane.net> <1381193255.25702.4.camel@vanquo.pezone.net> In-Reply-To: <1381193255.25702.4.camel@vanquo.pezone.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 10/07/2013 08:47 PM, Peter Eisentraut wrote: > > I suspect this line > > submake-libpq: $(libdir)/libpq.so ; > > will cause problems on platforms with a different extension (e.g. OS X). suggested fix is below. cheers andrew diff --git a/src/Makefile.global.in b/src/Makefile.global.in index bb732bb..b562378 100644 --- a/src/Makefile.global.in +++ b/src/Makefile.global.in @@ -422,7 +422,11 @@ ifndef PGXS submake-libpq: $(MAKE) -C $(libpq_builddir) all else -submake-libpq: $(libdir)/libpq.so ; +ifneq ($(PORTNAME),cygwin) +submake-libpq: $(libdir)/libpq$(DLSUFFIX) ; +else +submake-libpq: $(libdir)/cygpq$(DLSUFFIX) ; +endif endif ifndef PGXS -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers