Feedback-ID: ie0a040ee:Fastmail
Message-ID: <5255e75e-5a66-41ac-99d3-1998283b86e6@eisentraut.org>
Date: Sun, 12 May 2024 16:32:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Requiring LLVM 14+ in PostgreSQL 18
To: Thomas Munro <thomas.munro@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <CA+hUKG+SOP-aR=YF_n0dtXGWeCy6x+Cn-RMWURU5ySQdmeKW1Q@mail.gmail.com>
 <CA+hUKGLXr0Rjz_6PQrNWe7Z-k7_G-MAHoh1DP+A-sxw0qpYEDQ@mail.gmail.com>
 <CA+hUKGLFNFMOPPME6mpkGeve0+6CRrZLMTKs+MmBGJp4vLcJ=A@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CA+hUKGLFNFMOPPME6mpkGeve0+6CRrZLMTKs+MmBGJp4vLcJ=A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/5255e75e-5a66-41ac-99d3-1998283b86e6%40eisentraut.org>
Precedence: bulk

On 24.04.24 01:43, Thomas Munro wrote:
> Rebased over ca89db5f.

These patches look fine to me.  The new cut-off makes sense, and it does 
save quite a bit of code.  We do need to get the Cirrus CI Debian images 
updated first, as you had already written.

As part of this patch, you also sneak in support for LLVM 18 
(llvm-config-18, clang-18 in configure).  Should this be a separate patch?

And as I'm looking up how this was previously handled, I notice that 
this list of clang-NN versions was last updated equally sneakily as part 
of your patch to trim off LLVM <10 (820b5af73dc).  I wonder if the 
original intention of that configure code was that maintaining the 
versioned list above clang-7/llvm-config-7 was not needed, because the 
unversioning programs could be used, or maybe because pkg-config could 
be used.  It would be nice if we could get rid of having to update that.