Message-ID: <525A85DA.6010206@cybertec.at>
Date: Sun, 13 Oct 2013 13:36:58 +0200
From: Boszormenyi Zoltan <zb@cybertec.at>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Alvaro Herrera <alvherre@2ndquadrant.com>
CC: Peter Eisentraut <peter_e@gmx.net>, Noah Misch <noah@leadboat.com>,
 Michael Meskes <meskes@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>,
 PG Hackers <pgsql-hackers@postgresql.org>,
 Heikki Linnakangas <hlinnakangas@vmware.com>,
 Bruce Momjian <bruce@momjian.us>,
 =?ISO-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= <hs@cybertec.at>
Subject: Re: ECPG FETCH readahead
References: <4F8CEB5A.100@cybertec.at>
 <20120417044819.GA9043@feivel.credativ.lan> <4F95613B.2030904@cybertec.at>
 <20120424081714.GA12034@feivel.credativ.lan> <520F4B90.2010800@cybertec.at>
 <5226EA00.6040202@cybertec.at> <1378517102.7389.2.camel@vanquo.pezone.net>
 <522B7130.8040006@cybertec.at> <1378775047.14736.0.camel@vanquo.pezone.net>
 <522EA559.4090105@cybertec.at> <20131010221648.GK4825@eldon.alvh.no-ip.org>
In-Reply-To: <20131010221648.GK4825@eldon.alvh.no-ip.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

2013-10-11 00:16 keltezéssel, Alvaro Herrera írta:
> Boszormenyi Zoltan escribió:
>> 2013-09-10 03:04 keltezéssel, Peter Eisentraut írta:
>>> You need to update the dblink regression tests.
>> Done.
> Dude, this is an humongous patch.

You *know* that the patch is available in pieces at https://github.com/zboszor/ecpg-readahead
right? You must have read the new "initial" announcement at
http://archives.postgresql.org/message-id/520F4B90.2010800@cybertec.at

You can review and merge them one by one.
The transformation of ecpg_execute() and friends starts at
2d04ff83984c63c34e55175317e3e431eb58e00c

>    I was shocked by it initially, but on
> further reading, I observed that it's only a huge patch which also does
> some mechanical changes to test output.  I think it'd be better to split
> the part that's responsible for the changed lines in test output
> mentioning "ecpg_process_output".

It's 1e0747576e96aae3ec8c60c46baea130aaf8916e in the above repository.

Also, another huge regression test patch is where the cursor readahead
is enabled unconditionally: 27e43069082b29cb6fa4d3414e6484ec7fb80cbe

>    That should be a reasonably small
> patch which changes ecpg_execute slightly and adds the new function, is
> followed by the enormous resulting mechanical changes in test output.
> It should be possible to commit that relatively quickly.  Then there's
> the rest of the patch, which would adds a huge pile of new code.
>
> I think there are some very minor changes to backend code as well --
> would it make sense to post that as a separate piece?

It's 2ad207e6371a33d6a985c76ac066dd51ed5681cb
Also, cd881f0363b1aff1508cfa347e8df6b4981f0ee7 to fix the dblink regression test.

Best regards,
Zoltán Böszörményi

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers