From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Maciek Sakrejda <m.sakrejda@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
        Cary Huang <cary.huang@highgo.ca>, pgsql-hackers@lists.postgresql.org
Subject: Re: warn if GUC set to an invalid shared library
In-reply-to: <20221031133120.GO16921@telsasoft.com>
References: <20220722015412.GA7789@telsasoft.com>
 <CAOtHd0Ca3o_YX-2xC+0SOJD242QDHKCS16bG2AX9QQkKsdBF7Q@mail.gmail.com>
 <675610.1658512401@sss.pgh.pa.us> <20220722183557.GC7789@telsasoft.com>
 <729940.1658516423@sss.pgh.pa.us> <20220722191443.GE7789@telsasoft.com>
 <734432.1658518007@sss.pgh.pa.us> <20220902222458.GC31833@telsasoft.com>
 <20221029174053.GA19704@telsasoft.com>
 <CAOtHd0DXpECx=w556LQQQyMG7bRKSStsr=wyF=5PN3TBAW3nCg@mail.gmail.com>
 <20221031133120.GO16921@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Mon, 31 Oct 2022 08:31:20 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <527890.1667223785.1@sss.pgh.pa.us>
Date: Mon, 31 Oct 2022 09:43:05 -0400
Message-ID: <527891.1667223785@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/527891.1667223785%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Sun, Oct 30, 2022 at 04:12:33PM -0700, Maciek Sakrejda wrote:
>> Also, for what it's worth, I think requiring the libraries to be in
>> place before running ALTER SYSTEM does not really seem that onerous. I
>> can't really think of use cases it precludes.

> Right now, it's allowed to set the GUC before installing the shlib.
> That's a supported case (see the 11 month old messages toward the
> beginning of this thread).

Yeah, I am afraid that you will break assorted dump/restore and
pg_upgrade scenarios if you insist on that.

			regards, tom lane