From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: [HACKERS] pgbench - allow to store select results into variables
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Stephen Frost <sfrost@snowman.net>,
 PostgreSQL Developers <pgsql-hackers@postgresql.org>
References: <alpine.DEB.2.20.1708132029250.15606@lancre>
 <CAFj8pRDukEVowiGddVs9P9oNUrKui8pRm29kJUjZgG-ZjcCN=Q@mail.gmail.com>
 <alpine.DEB.2.20.1709081916410.3568@lancre>
 <alpine.DEB.2.20.1710201836530.15170@lancre>
 <CAFj8pRCGNRALRm6r2n-9iZQENJ92J3Hm=17mwXKeERXuNuAq7g@mail.gmail.com>
 <alpine.DEB.2.20.1710251209330.24229@lancre>
 <alpine.DEB.2.20.1801100952040.2283@lancre>
 <alpine.DEB.2.20.1803241024500.13537@lancre>
 <20180407031725.GX27724@tamriel.snowman.net>
 <alpine.DEB.2.20.1804071734480.4721@lancre>
 <20180408000001.GD27724@tamriel.snowman.net>
 <alpine.DEB.2.20.1804080732470.4721@lancre>
 <alpine.DEB.2.20.1804271819510.8704@lancre>
 <abaeb25e-f98a-4c96-92ad-f178a27dc8b5@2ndQuadrant.com>
 <alpine.DEB.2.21.1808140012360.2727@lancre>
Message-ID: <527f7e3e-402f-4043-b370-2e11ca84d19e@2ndQuadrant.com>
Date: Tue, 14 Aug 2018 06:47:43 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1808140012360.2727@lancre>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-MW
Precedence: bulk


On 08/13/2018 06:30 PM, Fabien COELHO wrote:
>
> Hello Andrew,
>
>>> Attached is v18, another basic rebase after some perl automatic 
>>> reindentation.
>>
>> This patch contains CRLF line endings
>
> Alas, not according to "file" nor "hexdump" (only 0A, no 0D) on my 
> local version, AFAICS.
>
> What happens on the path and what is done by mail clients depending on 
> the mime type is another question (eg text/x-diff or text/plain).


It's not done by my MUA, and it's present in your latest posted patch. 
If anything I'd suspect your MUA:


andrew@emma*$ curl -s 
https://www.postgresql.org/message-id/attachment/64237/pgbench-into-19.patch 
| head -n 3 | od -c
0000000   d   i   f   f       -   -   g   i   t       a   /   d o   c
0000020   /   s   r   c   /   s   g   m   l   /   r   e   f   / p   g
0000040   b   e   n   c   h   .   s   g   m   l       b   /   d o   c
0000060   /   s   r   c   /   s   g   m   l   /   r   e   f   / p   g
0000100   b   e   n   c   h   .   s   g   m   l  \r  \n   i   n d   e
0000120   x       8   8   c   f   8   b   3   9   3   3   .   . 9   4
0000140   6   f   0   8   0   0   5   d       1   0   0   6   4   4 \r
0000160  \n   -   -   -       a   /   d   o   c   /   s   r   c /   s
0000200   g   m   l   /   r   e   f   /   p   g   b   e   n   c h   .
0000220   s   g   m   l  \r  \n


The gzipped version you also attached did not have the CRs.


cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services