Content-Type: multipart/mixed; boundary="------------eOoouq4fgeUPPKTnsPocEzK0"
Message-ID: <529295b2-6ba9-4dae-acd1-20a9c6fb8f9a@gmail.com>
Date: Thu, 5 Sep 2024 15:41:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Andrei Lepikhov <lepihov@gmail.com>
Subject: Re: Create syscaches for pg_extension
To: Michael Paquier <michael@paquier.xyz>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Alexander Korotkov <aekorotkov@gmail.com>
References: <CAGECzQTWm9sex719Hptbq4j56hBGUti7J9OWjeMobQ1ccRok9w@mail.gmail.com>
 <CAFj8pRB6UES3yPH8mfvPnt=uknNcR9JdnLXcu2QW4C3bTezgDg@mail.gmail.com>
 <CAPpHfdsQnXcKZT2D7Evv-uuugcbToOri5fnoNcMiqLq9UtyWXQ@mail.gmail.com>
 <ZsLkam053DkOCOdk@paquier.xyz> <ZsaZPLjUUbzn7Qp0@paquier.xyz>
Content-Language: en-US
In-Reply-To: <ZsaZPLjUUbzn7Qp0@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/529295b2-6ba9-4dae-acd1-20a9c6fb8f9a%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------eOoouq4fgeUPPKTnsPocEzK0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 22/8/2024 03:49, Michael Paquier wrote:
> On Mon, Aug 19, 2024 at 03:21:30PM +0900, Michael Paquier wrote:
>> I won't hide that I've wanted that in the past..
> 
> And I have bumped into a case where this has been helpful today, so
> applied.  Thanks!
It had been my dream, too, for years. But the reason was the too-costly 
call of the get_extension_oid routine (no less than pgbench 2-3% of 
overhead when checked it in the planner hook).
It seems that the get_extension_oid routine was not modified when the 
sys cache was introduced. What is the reason? It may be that this 
routine is redundant now, but if not, and we want to hold the API that 
extensions use, maybe we should rewrite it, too.
See the attachment proposing changes.

-- 
regards, Andrei Lepikhov

--------------eOoouq4fgeUPPKTnsPocEzK0
Content-Type: text/plain; charset=UTF-8;
 name="0001-Use-EXTENSIONNAME-syscache-to-find-extension-oid.patch"
Content-Disposition: attachment;
 filename*0="0001-Use-EXTENSIONNAME-syscache-to-find-extension-oid.patch"
Content-Transfer-Encoding: base64

RnJvbSBjMjcyNDFlODI0ZGUzYmY4MmIxYWM3ZWYyNjNmZWMxM2ZlOGYwZWQ2IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmVpIFYuIExlcGlraG92IiA8bGVwaWhvdkBn
bWFpbC5jb20+CkRhdGU6IFRodSwgNSBTZXAgMjAyNCAxNTowMzoxMCArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIFVzZSBFWFRFTlNJT05OQU1FIHN5c2NhY2hlIHRvIGZpbmQgZXh0ZW5zaW9u
IG9pZC4KCi0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMvZXh0ZW5zaW9uLmMgfCAyOCArKyst
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z
KCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5k
cy9leHRlbnNpb24uYyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2V4dGVuc2lvbi5jCmluZGV4
IDE2NDNjOGM2OWEuLmU4ZmJlNWFmZjAgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1h
bmRzL2V4dGVuc2lvbi5jCisrKyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2V4dGVuc2lvbi5j
CkBAIC02NCw2ICs2NCw3IEBACiAjaW5jbHVkZSAidXRpbHMvbWVtdXRpbHMuaCIKICNpbmNs
dWRlICJ1dGlscy9yZWwuaCIKICNpbmNsdWRlICJ1dGlscy9zbmFwbWdyLmgiCisjaW5jbHVk
ZSAidXRpbHMvc3lzY2FjaGUuaCIKICNpbmNsdWRlICJ1dGlscy92YXJsZW5hLmgiCiAKIApA
QCAtMTQ1LDMyICsxNDYsOSBAQCBPaWQKIGdldF9leHRlbnNpb25fb2lkKGNvbnN0IGNoYXIg
KmV4dG5hbWUsIGJvb2wgbWlzc2luZ19vaykKIHsKIAlPaWQJCQlyZXN1bHQ7Ci0JUmVsYXRp
b24JcmVsOwotCVN5c1NjYW5EZXNjIHNjYW5kZXNjOwotCUhlYXBUdXBsZQl0dXBsZTsKLQlT
Y2FuS2V5RGF0YSBlbnRyeVsxXTsKLQotCXJlbCA9IHRhYmxlX29wZW4oRXh0ZW5zaW9uUmVs
YXRpb25JZCwgQWNjZXNzU2hhcmVMb2NrKTsKLQotCVNjYW5LZXlJbml0KCZlbnRyeVswXSwK
LQkJCQlBbnVtX3BnX2V4dGVuc2lvbl9leHRuYW1lLAotCQkJCUJURXF1YWxTdHJhdGVneU51
bWJlciwgRl9OQU1FRVEsCi0JCQkJQ1N0cmluZ0dldERhdHVtKGV4dG5hbWUpKTsKLQotCXNj
YW5kZXNjID0gc3lzdGFibGVfYmVnaW5zY2FuKHJlbCwgRXh0ZW5zaW9uTmFtZUluZGV4SWQs
IHRydWUsCi0JCQkJCQkJCSAgTlVMTCwgMSwgZW50cnkpOwotCi0JdHVwbGUgPSBzeXN0YWJs
ZV9nZXRuZXh0KHNjYW5kZXNjKTsKIAotCS8qIFdlIGFzc3VtZSB0aGF0IHRoZXJlIGNhbiBi
ZSBhdCBtb3N0IG9uZSBtYXRjaGluZyB0dXBsZSAqLwotCWlmIChIZWFwVHVwbGVJc1ZhbGlk
KHR1cGxlKSkKLQkJcmVzdWx0ID0gKChGb3JtX3BnX2V4dGVuc2lvbikgR0VUU1RSVUNUKHR1
cGxlKSktPm9pZDsKLQllbHNlCi0JCXJlc3VsdCA9IEludmFsaWRPaWQ7Ci0KLQlzeXN0YWJs
ZV9lbmRzY2FuKHNjYW5kZXNjKTsKLQotCXRhYmxlX2Nsb3NlKHJlbCwgQWNjZXNzU2hhcmVM
b2NrKTsKKwlyZXN1bHQgPSBHZXRTeXNDYWNoZU9pZDEoRVhURU5TSU9OTkFNRSwgQW51bV9w
Z19leHRlbnNpb25fb2lkLAorCQkJCQkJCUNTdHJpbmdHZXREYXR1bShleHRuYW1lKSk7CiAK
IAlpZiAoIU9pZElzVmFsaWQocmVzdWx0KSAmJiAhbWlzc2luZ19vaykKIAkJZXJlcG9ydChF
UlJPUiwKLS0gCjIuNDYuMAoK

--------------eOoouq4fgeUPPKTnsPocEzK0--