Message-ID: <52A59D10.7020209@lab.ntt.co.jp>
Date: Mon, 09 Dec 2013 19:36:00 +0900
From: KONDO Mitsumasa <kondo.mitsumasa@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: fabriziomello@gmail.com
CC: Robert Haas <robertmhaas@gmail.com>, Simon Riggs <simon@2ndquadrant.com>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Time-Delayed Standbys
References: 
 <CAFcNs+oXq5ZPaKARRn3VZGzX+AnTZCaEjR6VmQT_tvoFiqgaSg@mail.gmail.com>
	<CA+U5nML64Y7Nf0mpQirk-tOWrV+ZQ3y8DdRgk2mP+e3kGT16Mw@mail.gmail.com>
	<CAFcNs+rAJO6wvzN8zQCTUpii0mC9Ax51JxVhWTsos7xsFdwXjw@mail.gmail.com>
	<CA+TgmoaCL4G+YotjjjFM+J_h0nSkp4gXiiBPDQGHxTcc_T0w-w@mail.gmail.com>
 <CAFcNs+r-GyizHAPDvRz=3XR3BYLUqxpqxrvJq8spk4PJe5hxAA@mail.gmail.com>
In-Reply-To: 
 <CAFcNs+r-GyizHAPDvRz=3XR3BYLUqxpqxrvJq8spk4PJe5hxAA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi Fabrízio,

I test your v4 patch, and send your review comments.

* Fix typo
 > 49 -# commited transactions from the master, specify a recovery time delay.
 > 49 +# committed transactions from the master, specify a recovery time delay.

* Fix white space
 > 177 -               if (secs <= 0 && microsecs <=0)
 > 177 +               if (secs <= 0 && microsecs <=0 )

* Add functionality (I propose)
We can set negative number at min_standby_apply_delay. I think that this feature
is for world wide replication situation. For example, master server is in Japan 
and slave server is in San Francisco. Japan time fowards than San Francisco time
. And if we want to delay in this situation, it can need negative number in 
min_standby_apply_delay. So I propose that time delay conditional branch change 
under following.
 > - if (min_standby_apply_delay > 0)
 > + if (min_standby_apply_delay != 0)
What do you think? It might also be working collectry.


* Problem 1
I read your wittened document. There is "PITR has not affected".
However, when I run PITR with min_standby_apply_delay=3000000, it cannot start 
server. The log is under following.
> [mitsu-ko@localhost postgresql]$ bin/pg_ctl -D data2 start
> server starting
> [mitsu-ko@localhost postgresql]$ LOG:  database system was interrupted; last known up at 2013-12-08 18:57:00 JST
> LOG:  creating missing WAL directory "pg_xlog/archive_status"
> cp: cannot stat `../arc/00000002.history':
> LOG:  starting archive recovery
> LOG:  restored log file "000000010000000000000041" from archive
> LOG:  redo starts at 0/41000028
> LOG:  consistent recovery state reached at 0/410000F0
> LOG:  database system is ready to accept read only connections
> LOG:  restored log file "000000010000000000000042" from archive
> FATAL:  cannot wait on a latch owned by another process
> LOG:  startup process (PID 30501) exited with exit code 1
> LOG:  terminating any other active server processes
We need recovery flag for controling PITR situation.


That's all for now.
If you are busy, please fix in your pace. I'm busy and I'd like to wait your 
time, too:-)

Regards,
-- 
Mitsumasa KONDO
NTT Open Source Software Center


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers