Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M242855=pgsql-hackers-arkari@postgresql.org>)
 id 1W6cTb-0007Wg-Dc
 for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Jan 2014 08:50:59 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M242855=pgsql-hackers-arkari@postgresql.org>)
 id 1W6cTa-0002Ae-U5
 for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Jan 2014 08:50:58 +0000
Received: from makus.postgresql.org ([2001:4800:7903:4::125])
 by malur.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <hlinnakangas@vmware.com>) id 1W6cTZ-0002AW-E1
 for pgsql-hackers@postgresql.org; Fri, 24 Jan 2014 08:50:57 +0000
Received: from smtp-outbound-1.vmware.com ([208.91.2.12])
 by makus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <hlinnakangas@vmware.com>) id 1W6cTW-00044j-Iu
 for pgsql-hackers@postgresql.org; Fri, 24 Jan 2014 08:50:56 +0000
Received: from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com
 [10.113.161.71])
 by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 26E6F28EE9;
 Fri, 24 Jan 2014 00:50:53 -0800 (PST)
Received: from zcs-prod-ext-mta-2.vmware.com (zcs-prod-ext-mta-2.vmware.com
 [10.113.62.224])
 by sc9-mailhost1.vmware.com (Postfix) with ESMTP id 22DAE18446;
 Fri, 24 Jan 2014 00:50:53 -0800 (PST)
Received: from zcs-prod-ext-mta-2.vmware.com (localhost.localdomain
 [127.0.0.1])
 by zcs-prod-ext-mta-2.vmware.com (Postfix) with ESMTP id 6464EC0051;
 Fri, 24 Jan 2014 00:51:31 -0800 (PST)
Received: from [192.168.1.90] (zimbra-prod-ext-proxy-vip.vmware.com
 [10.113.63.87])
 by zcs-prod-ext-mta-2.vmware.com (Postfix) with ESMTPSA;
 Fri, 24 Jan 2014 00:51:29 -0800 (PST)
Message-ID: <52E22968.2050100@vmware.com>
Date: Fri, 24 Jan 2014 10:50:48 +0200
From: Heikki Linnakangas <hlinnakangas@vmware.com>
Organization: VMware
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: Alexander Korotkov <aekorotkov@gmail.com>
CC: Tomas Vondra <tv@fuzzy.cz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GIN improvements part 1: additional information
References: 
 <CAPpHfdutJEC9+6vWX579afZKzdHKCT2wzDkAEom1XmiXEwF3pw@mail.gmail.com>
 <52B49C34.8060300@vmware.com>
 <CA+HiwqGO91OEE0ZBa0q2RqFEKm5dy5VzXrf7uoYObw9BCKSEVA@mail.gmail.com>
 <CAPpHfduBDxQ7Tw5bZCCgxmJzNHDRG6eELAuseuCEvKt=dw0Yfw@mail.gmail.com>
 <52D0A947.6050706@fuzzy.cz>
 <CAPpHfdskbPbjWYJhkd-FkZCKEUZd03PRAw05NyT0Hd-jxWOyfg@mail.gmail.com>
 <52D478F2.6070005@fuzzy.cz> <52D5E1BC.3000208@fuzzy.cz>
 <CAPpHfdv9Pheu5atEEUk75f_S1nf6vCoRqge2yUQ1v3xgZ4UP3g@mail.gmail.com>
 <CAPpHfds0A03zwmYdhKUg6s01Vq1p30n01=3c-tct264QTpV--Q@mail.gmail.com>
 <52D9789E.3030202@vmware.com> <52DDD51E.2080408@fuzzy.cz>
 <52DE3F55.80103@vmware.com> <52DEE4BF.6010203@vmware.com>
 <CAPpHfdtk+1s3EYE5LZFQr8Xb2Ms_apt67Dj0jb3uAyZj9m34XA@mail.gmail.com>
 <52DF819E.4070507@vmware.com>
 <CAPpHfdu2QBSFvBs=NqssSt-FeXgxhFzDivkso-fwC3VfiV_5eA@mail.gmail.com>
 <52DFFFD0.6020708@vmware.com>
 <CAPpHfdtgqY8AXnCQ7E2v6Y7FLtUTK1YE9wPNSvTCNOyQ8j0eAg@mail.gmail.com>
 <CAPpHfduaLDYjXRw8q5+Fnjbe_3SgvKZbNHXJ952VbFLi5H6HDQ@mail.gmail.com
 >
In-Reply-To: 
 <CAPpHfduaLDYjXRw8q5+Fnjbe_3SgvKZbNHXJ952VbFLi5H6HDQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Pg-Spam-Score: -7.5 (-------)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 01/24/2014 10:03 AM, Alexander Korotkov wrote:
> ITSM I found this bug. ginVacuumPostingTreeLeaf re-encodes only some
> segments. Others are not even re-palloced. They are moved left
> in dataPlaceToPageLeafRecompress by memcpy. But it's incorrect to with
> memcpy, proper solution is memmove. Using memcpy platform dependently can
> lead to page corruption. Another solution is to re-palloc segments in
> ginVacuumPostingTreeLeaf.

Good catch. Thanks, committed, changing memcpy to memmove. Will have to 
switch to pallocing everything in the future, if we make leafRepackItems 
smarter, so that it doesn't rewrite all the segments after the first 
modified one.

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers