Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7fGa-003XVv-Ed for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 18:56:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u7fGY-009A15-LQ for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 18:56:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7ZrX-006KXR-Fo for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 13:10:04 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7ZrV-001XOE-04 for pgsql-hackers@postgresql.org; Wed, 23 Apr 2025 13:10:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1745413797; bh=BAqKFXFU7+furD9ccTyu0COAt/0rKlYJtKZunFuPZPE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:From; b=rAm2Kp4wSjix2z+wTjlzJ6RdpkzIeP6Q7KqbTye6s+BIyjZT/5xYdkfYiprL/9vTJ oIYlYXvvlDpJ1DBZfq5ugZn7reU98rUdzP2Wk9iCKvZ+lZtolfh5Ah2LmIMi9LvkGL AB1i3PJi65UTQOevtYn4WV+1eP0yAVNQKZ32oOq7zm4/HPYFBasQCNMvnsS8uFqWuq 3ENcnd2f3A+ZsD1dn2QyUJEBGKtP5oYvymWtuG7tojKgYsYJt0q8/6Dfpgp32dldnt KunKFkf4XCfsnb3D+GotvdsQpy1TZjyJcN8dHMK573966HL12j5bjiWxxXcw1vtMB2 6zLSYlFq8XDvg== Received: from mail.postgrespro.ru (webmail-slave-mstn.l.postgrespro.ru [192.168.2.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: m.korotkov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id ADE1160EFB; Wed, 23 Apr 2025 16:09:57 +0300 (MSK) MIME-Version: 1.0 Date: Wed, 23 Apr 2025 16:09:57 +0300 From: m.korotkov@postgrespro.ru To: Andrey Borodin Cc: PostgreSQL Hackers Subject: Re: [PATCH] dynahash: add memory allocation failure check In-Reply-To: References: <219bdccd460510efaccf90b57e5e5ef2@postgrespro.ru> Message-ID: <52c350a319d9e70d62da90912c164c48@postgrespro.ru> X-Sender: m.korotkov@postgrespro.ru Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/04/23 10:02:00 #27917461 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrey Borodin wrote 2025-04-23 12:46: > It seems there are a lot of cases of MCXT_ALLOC_NO_OOM, perhaps should > we check them all? Yep, I think we should. I found this issue with the Svace static analyzer, and it might have missed other issues. Perhaps a more comprehensive investigation is needed here. --- Best regards, Maksim Korotkov