Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WIFX1-0004Jv-V6 for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Feb 2014 10:46:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1WIFX1-0005uZ-BX for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Feb 2014 10:46:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WIFWz-0005uO-Pc for pgsql-hackers@postgresql.org; Tue, 25 Feb 2014 10:46:33 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WIFWw-000670-F4 for pgsql-hackers@postgresql.org; Tue, 25 Feb 2014 10:46:32 +0000 Received: from mfs6.rdh.ecl.ntt.co.jp (mfs6.rdh.ecl.ntt.co.jp [129.60.39.149]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id s1PAkQkp021420; Tue, 25 Feb 2014 19:46:26 +0900 Received: from mfs6.rdh.ecl.ntt.co.jp (localhost.localdomain [127.0.0.1]) by mfs6.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id 83CB3E012C; Tue, 25 Feb 2014 19:46:26 +0900 (JST) Received: from imail3.m.ecl.ntt.co.jp (imail3.m.ecl.ntt.co.jp [129.60.5.248]) by mfs6.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id 6E34CE012B; Tue, 25 Feb 2014 19:46:26 +0900 (JST) Received: from [129.60.241.144] ([129.60.241.144]) by imail3.m.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id s1PAkQG5029000; Tue, 25 Feb 2014 19:46:26 +0900 Message-ID: <530C7464.6020006@lab.ntt.co.jp> Date: Tue, 25 Feb 2014 19:45:56 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Shigeru Hanada CC: PostgreSQL-development Subject: Re: inherit support for foreign tables References: <12432.1384406906@sss.pgh.pa.us> <10163.1384786524@sss.pgh.pa.us> <52DDD071.9090405@ak.jp.nec.com> <52E5F3FD.6050000@lab.ntt.co.jp> <52E6137B.1080704@lab.ntt.co.jp> <52F4D206.7010704@lab.ntt.co.jp> <52F8BF6F.2050204@lab.ntt.co.jp> <52FDF74A.5070203@lab.ntt.co.jp> In-Reply-To: <52FDF74A.5070203@lab.ntt.co.jp> Content-Type: text/plain; charset=Shift_JIS Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org In addition to an issue pointed out recently by Horiguchi-san, I've found there is another issue we have to discuss. That is, we can't build any parameterized Append paths for an inheritance tree that contains at least one foreign table, in set_append_rel_pathlist(). This is because the patch doesn't take into consideration "reparameterization" for paths for a foreign table, which attempts to modify these paths to have greater parameterization so that each child path in the inheritance tree can have the exact same parameterization. To do so, I think we would need to add code for the foreign-table case to reparameterize_path(). And I think we should introduce a new FDW routine, say ReparameterizeForeignPath() because the processing would be performed best by the FDW itself. Comments are welcome! Thanks, Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers