Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPrH1-00033D-1Y for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Feb 2023 20:42:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrGz-0001d5-It for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Feb 2023 20:42:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPrGz-0001Yg-8D for pgsql-hackers@lists.postgresql.org; Wed, 08 Feb 2023 20:42:33 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPrGw-0002qs-9y for pgsql-hackers@lists.postgresql.org; Wed, 08 Feb 2023 20:42:32 +0000 Received: by mail-ej1-x631.google.com with SMTP id ud5so467488ejc.4 for ; Wed, 08 Feb 2023 12:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qmlQSLWKvKmV+CCoizUO/KSmVfPYghSDbaHlXWDNtuY=; b=Bp5/u7/a+FiD5xshb68msnDr2RounH4vbwL5xmmPG8O/MGGyrtiY8KfKBsGoFUjuRA 5PCGecBHITqNR0xfXQ3jQTf0ZZC8NqaVieP8TpPABv/eyBB9DtARQ5hBSuSkUJP7Cux6 o3to8K6Hj8rjAYrp0keR8zGGkGRO11Lx3Qtr3TaIJAgFbtgd0BrL2eijovXebauiqIhn veodedy6KmADZIH1/c7bp+x+DrNRwrS9FDu37RtGZRVdGPx5SMt8Ju6Hr0WBZxhH3oL8 leIBsKVc5Uw/tl+5WFVY3L3F9wK4DUB4wQNPoVmr8CbMClKO88+zXO21oaX/I/iXehnN ryLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qmlQSLWKvKmV+CCoizUO/KSmVfPYghSDbaHlXWDNtuY=; b=FkIL35uHE6IJMBZur0Jkht1pXikV3sHOowmalzu2UQJlxh4js/9549w52zdBySldnr Wurx8n+PTb9f9S6Z8OLI2tHDSZ++BavJYEOpBFdnSu7sbUBjAJNPCiFrtJvqDhk/ZfsN Tatu3GppFOSaC4KFJWf1/bq1c4c5NDDIPIwfgNvPE4wb/TZk0hCAaz31ltmtM3tDbqE3 AIWLMsWfNBF/UTELn5kDNDo3sHJeI4bIXWR8Jn3meeFd84bwyH5Wb5/W+XkdYDu7cFG5 AQsHlHgsPa1lQ4ZGjBFV+5O+89asLEEeUVyhp4enVRU18d3sYZgLhRN2sC2n7xT6Amds Khzw== X-Gm-Message-State: AO0yUKWlw8MtcF96pRkPVkCYUWDIOMnVL5U1RQq0NPVMngZ+/vZyhyRZ GcVh0ZyBM717ej6L/Oor5nGAMszg55cTjN26wimtC0EgsoTVvUavFe/fBOt4nGgEYRyl6nBRvkm giUKkViDed05XYuitHGIo5EY/iwOv6mqHe7G+y2eP1sTFVh5w7wZ+lKkPLn2PJ/zrUIb//aA/an 9xdTKe6n2lzd7sUtb1tvIwGfZ3MTahvD7wRCYDGj3+ZD7Orqxfa0q1U6msKzH7vSK8U7148zfzZ jo1iOD/Dzk83pKkbJLIQI2eCMHJfGo/2GjbJrqQSqgXaGUqIqM+Ks19Sq51v/5kgmCh10U= X-Google-Smtp-Source: AK7set8IGTe0+5h2mQ05MZjmGYx4PEYiGT3qR8ngzPHOrooCLg1denGEtpQcAv4vjX013pXx9CXgWQ== X-Received: by 2002:a17:906:4913:b0:88c:9b39:23c6 with SMTP id b19-20020a170906491300b0088c9b3923c6mr9133270ejq.14.1675888948395; Wed, 08 Feb 2023 12:42:28 -0800 (PST) Received: from [10.137.0.17] (cst-prg-3-194.cust.vodafone.cz. [46.135.3.194]) by smtp.gmail.com with ESMTPSA id d4-20020a170907272400b00871075bfcfesm8728619ejl.133.2023.02.08.12.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 12:42:28 -0800 (PST) Message-ID: <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> Date: Wed, 8 Feb 2023 21:42:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: daitch_mokotoff module Content-Language: en-US To: Dag Lem , Alvaro Herrera Cc: Paul Ramsey , PostgreSQL Hackers References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/8/23 15:31, Dag Lem wrote: > Alvaro Herrera writes: > >> On 2023-Jan-17, Dag Lem wrote: >> >>> + * Daitch-Mokotoff Soundex >>> + * >>> + * Copyright (c) 2021 Finance Norway >>> + * Author: Dag Lem >> >> Hmm, I don't think we accept copyright lines that aren't "PostgreSQL >> Global Development Group". Is it okay to use that, and update the year >> to 2023? (Note that answering "no" very likely means your patch is not >> candidate for inclusion.) Also, we tend not to have "Author:" lines. >> > > You'll have to forgive me for not knowing about this rule: > > grep -ER "Copyright.*[0-9]{4}" contrib/ | grep -v PostgreSQL > > In any case, I have checked with the copyright owner, and it would be OK > to assign the copyright to "PostgreSQL Global Development Group". > I'm not entirely sure what's the rule either, and I'm a committer. My guess is these cases are either old and/or adding a code that already existed elsewhere (like some of the double metaphone, for example), or maybe both. But I'd bet we'd prefer not adding more ... > To avoid going back and forth with patches, how do you propose that the > sponsor and the author of the contributed module should be credited? > Woule something like this be acceptable? > We generally credit contributors in two ways - by mentioning them in the commit message, and by listing them in the release notes (for individual features). > /* > * Daitch-Mokotoff Soundex > * > * Copyright (c) 2023, PostgreSQL Global Development Group > * > * This module was sponsored by Finance Norway / Trafikkforsikringsforeningen > * and implemented by Dag Lem > * > ... > > [...] > >> >> We don't keep a separate copyright statement in the file; rather we >> assume that all files are under the PostgreSQL license, which is in the >> COPYRIGHT file at the top of the tree. Changing it thus has the side >> effect that these disclaim notes refer to the University of California >> rather than "the Author". IANAL. > > OK, no problem. Note that you will again find counterexamples under > contrib/ (and in some other places): > > grep -R "Permission to use" . > >> I think we should add SPDX markers to all the files we distribute: >> /* SPDX-License-Identifier: PostgreSQL */ >> >> https://spdx.dev/ids/ >> https://spdx.org/licenses/PostgreSQL.html > > As far as I can tell, this is not included in any file so far, and is > thus better left to decide and implement by someone else. > I don't think Alvaro was suggesting this patch should do that. It was more a generic comment about what the project as a whole might do. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company