Message-ID: <531EA264.1000205@lab.ntt.co.jp>
Date: Tue, 11 Mar 2014 14:43:00 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.0;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
CC: shigeru.hanada@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: inherit support for foreign tables
References: <530C7464.6020006@lab.ntt.co.jp>
	<20140226.124857.17636723.horiguchi.kyotaro@lab.ntt.co.jp>
	<20140310.172911.79971075.horiguchi.kyotaro@lab.ntt.co.jp>
 <20140311.140751.146429295.horiguchi.kyotaro@lab.ntt.co.jp>
In-Reply-To: <20140311.140751.146429295.horiguchi.kyotaro@lab.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

(2014/03/11 14:07), Kyotaro HORIGUCHI wrote:
>> This seems far better than silently performing the command,
>> except for the duplicated message:( New bitmap might required to
>> avoid the duplication..
>
> I rewrote it in more tidy way. ATController collects all affected
> tables on ATRewriteCatalogs as first stage, then emit NOTICE
> message according to the affected relations list. The message
> looks like,
>
> | =# alter table passwd alter column uname set default 'hoge';
> | NOTICE:  This command affects 2 foreign tables: cf1, cf2
> | ALTER TABLE
>
> Do you feel this too large or complicated? I think so a bit..

No.  I think that would be a useful message for the user.

My feeling is it would be better to show this kind of messages for all 
the affected tables whether or not the affected ones are foreign.  How 
about introducing a VERBOSE option for ALTER TABLE?  Though, I think 
that should be implemented as a separate patch.

Thanks,

Best regards,
Etsuro Fujita


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers