Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol3s3-0000Ar-5w for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Oct 2022 07:52:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ol3s1-000255-Ue for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Oct 2022 07:52:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol3s1-00024i-Ez for pgsql-hackers@lists.postgresql.org; Wed, 19 Oct 2022 07:52:09 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ol3rw-0003QS-4z for pgsql-hackers@lists.postgresql.org; Wed, 19 Oct 2022 07:52:06 +0000 Received: by mail-wr1-x434.google.com with SMTP id w18so27692726wro.7 for ; Wed, 19 Oct 2022 00:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jbuUkRbgqCoPA18ycBmVnN1DPlPjjt0c197KJz7+lgk=; b=Fl6euMyNAFQoYXEr+zc9ZMV6TyhjCoM3wDeibeATUtgdIDjHUZ0jat6gykc0aGsF6C tL9dk+pjAHYU+HxPIHYmY6LiAJKJqElYBS5YWZPTZCg8w/bM1h4EQer55TNAiTJL98N2 IJjtZ2FBRByZmJLtOJaD526Y+vvRMQkUVYtpZMbI0uGX3Givd5/WzEsAdS2XqoHSvLEq uhiiBIPwXIdZVGtflKoMjRAuJ8exOotHzRJ9xWXdxVlFoLine3tKBGEVU1pT37o8D79g JO6KdK8i8sLjU1ysf6iITcZoy6keCWPkwo7llDHOgCa5fM5kGVwvhUIwMG/8rwT9dl7c rWIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jbuUkRbgqCoPA18ycBmVnN1DPlPjjt0c197KJz7+lgk=; b=Pn2Z0P18My9QlADmoNH04Cmth78rJlcIyfN9ppCIoA7HCBfz03gPdkJK9mppm6N8tA hVGD+pRYjmM1RB0+zMPQheQmAWQsdMgO6uVPGSLW10iU6n8sLzs3BJNstSHdT9jK4GHO LTZmB+K1+ROsHyDKDlweA/KsGHee+AOlxsJucNH6gx4ewIY9uCxOZ9yQ6DhYR0CsWVf/ I+/mJxHCMZx903u0Ehgp4rJGsdchfhubCWqH3fnjVw93HyhFA/EkH+zC0+A3hlfzIKgP FcSKk5d0TMhvI84koYHTKtUHK1tKbH3CnhTSiVL5haCsxfElwxHtqGcVFUFPJRaPgbma k3og== X-Gm-Message-State: ACrzQf2sZI+JvSY0N9zUIJu545nCP8j5LU5RWBJ1jCsEQaEi9K2dx4gO aog3Bj0WjZprmNs1YAUGhoY= X-Google-Smtp-Source: AMsMyM5/qb+W9emnegIFpbQNDLmmeHA4dPId972xMfSVa06l9csmPwS/NYHiApNQ3feus8E66q3+Sw== X-Received: by 2002:a05:6000:788:b0:22e:412b:7959 with SMTP id bu8-20020a056000078800b0022e412b7959mr4054476wrb.491.1666165922731; Wed, 19 Oct 2022 00:52:02 -0700 (PDT) Received: from [192.168.0.194] ([54.239.6.188]) by smtp.gmail.com with ESMTPSA id z9-20020a5d44c9000000b00228d7078c4esm13138027wrr.4.2022.10.19.00.52.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 00:52:02 -0700 (PDT) Message-ID: <531b1394-bdb3-8b81-715c-c5bb49d0369f@gmail.com> Date: Wed, 19 Oct 2022 09:50:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: Patch proposal: make use of regular expressions for the username in pg_hba.conf To: Michael Paquier Cc: Tom Lane , Jacob Champion , PostgreSQL Hackers References: <607af3c9-e45d-3941-41a2-d21065d6594b@gmail.com> <5000f886-e640-b284-fa64-5cef28b6d272@gmail.com> Content-Language: en-US From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 10/19/22 3:18 AM, Michael Paquier wrote: > On Tue, Oct 18, 2022 at 09:14:21AM +0200, Drouvot, Bertrand wrote: >> BTW, what about adding a new TAP test (dedicated patch) to test the behavior >> in case of errors during the regexes compilation in pg_ident.conf and >> pg_hba.conf (not done yet)? (we could add it once this patch series is >> done). > > Perhaps, that may become tricky when it comes to -DEXEC_BACKEND (for > cases where no fork() implementation is available, aka Windows). But > a postmaster restart failure would generate logs that could be picked > for a pattern check? Right, that's how I'd see it. I'll give it a look. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com