From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: David Geier <geidav.pg@gmail.com>, Thomas Munro <thomas.munro@gmail.com>,
        Chao Li <li.evan.chao@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Consistently use palloc_object() and palloc_array()
In-reply-to: <aS-F6LkeDBEly9nz@paquier.xyz>
References: <ad0748d4-3080-436e-b0bc-ac8f86a3466a@gmail.com>
 <ED821EDD-6A1B-45B8-9005-31BCFFCB5A48@gmail.com>
 <a29b0cd9-576f-486f-ba45-5139ee33adcf@gmail.com>
 <524587.1764365323@sss.pgh.pa.us>
 <1e7f0c17-a965-4d5b-ad88-b435a4d97490@gmail.com>
 <CA+hUKGL+hiMRrAOqop1wmfpqTLg3GdyAJmO6KH6Dz3FjQvGN+w@mail.gmail.com>
 <143d3184-b575-49bd-8bc1-f37f45f010cc@gmail.com>
 <aS-F6LkeDBEly9nz@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 03 Dec 2025 09:35:52 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <534125.1764722446.1@sss.pgh.pa.us>
Date: Tue, 02 Dec 2025 19:40:46 -0500
Message-ID: <534126.1764722446@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/534126.1764722446%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> It may be a good idea to split the patch into two parts, at least:
> - One for the bulk of the changes, for the straight-forward changes.
> Most of what you are suggesting are that for palloc_object and
> palloc_array which are dropped-in replacements.  Checking that these
> assemble the same before and after offers one extra layer of
> confidence.
> - Second one for the more dubious changes.

Yeah, I was thinking the same.  Some of those might perhaps be bugs
that we want to back-patch, so they need to be looked at in a
different way.

			regards, tom lane