Message-ID: <534EEC61.7000006@2ndquadrant.com>
Date: Wed, 16 Apr 2014 22:47:29 +0200
From: Petr Jelinek <petr@2ndquadrant.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Robert Haas <robertmhaas@gmail.com>,
 Andres Freund <andres@2ndquadrant.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Antonin Houska <antonin.houska@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: bgworker crashed or not?
References: <20140416131052.GG17874@awork2.anarazel.de>
	<CA+TgmoYy2oJL7t-rknyVENm=vnqTTtb=R-TDkMsrMrgbhQDiew@mail.gmail.com>
	<20140416152803.GJ17874@awork2.anarazel.de>
	<CA+TgmoZPrzktkbwYRgv2fbhBi2_ty9BEtV6Gk-SSrERROZUkvw@mail.gmail.com>
	<20140416154412.GL17874@awork2.anarazel.de>	<27214.1397663665@sss.pgh.pa.us>
	<20140416160047.GM17874@awork2.anarazel.de>
	<CA+TgmoZe4zqRAX8rgpy9UWy=PE7=3B_1J34bTehEi25hCgr3kw@mail.gmail.com>
	<20140416161143.GN17874@awork2.anarazel.de>
	<CA+TgmoaefVEJeO7+D=VE35Aj2fkgZ3YVqWx8Svzd3v493iJSvg@mail.gmail.com>
	<20140416162837.GO17874@awork2.anarazel.de>
 <CA+TgmoZLwmkZ2O6T29qAb9EhO-9cyz4Rj9mjLQVkFe673CooWA@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoZLwmkZ2O6T29qAb9EhO-9cyz4Rj9mjLQVkFe673CooWA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 16/04/14 18:34, Robert Haas wrote:
> On Wed, Apr 16, 2014 at 12:28 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>> On 2014-04-16 12:20:01 -0400, Robert Haas wrote:
>>> On Wed, Apr 16, 2014 at 12:11 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>>> I'm still not seeing the problem.  It's the background worker's job to
>>> make sure that the right stuff gets logged, just as it would be for
>>> any other backend.  Trying to bolt some portion of the responsibility
>>> for that onto the postmaster is 100% wrong.
>>
>> Well, it already has taken on that responsibility, it's not my idea to
>> add it. I merely want to control more precisely what happens.s
>
> I think that's doubling down on an already-questionable design principle.
>
> Or if I may be permitted a more colloquial idiom:
>
> Luke, it's a trap.
>

Well the logging is just too spammy in general when it comes to dynamic 
bgworkers but that's easy to fix in the future, no need to make 
decisions for 9.4.

However I really don't like that I have to exit with exit code 1, which 
is normally used as failure, if I want to shutdown my dynamic bgworker 
once it has finished the work. And this behavior is something we can set 
properly only once...


-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers