Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cV2PC-0004hU-LI for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Jan 2017 20:36:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cV2PB-0007yA-GR for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Jan 2017 20:36:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cV2Nl-0006L5-N8 for pgsql-hackers@postgresql.org; Sat, 21 Jan 2017 20:35:29 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cV2Nf-0004Fj-2k for pgsql-hackers@postgresql.org; Sat, 21 Jan 2017 20:35:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v0LKZLRQ005376; Sat, 21 Jan 2017 15:35:21 -0500 From: Tom Lane To: David Bowen cc: Pavan Deolasee , Alvaro Herrera , pgsql-hackers Subject: Re: Failure in commit_ts tap tests In-reply-to: References: <20170120182702.tjjk2mh3t5keansh@alvherre.pgsql> <21212.1484939708@sss.pgh.pa.us> <26339.1485013196@sss.pgh.pa.us> <27447.1485014954@sss.pgh.pa.us> Comments: In-reply-to David Bowen message dated "Sat, 21 Jan 2017 14:03:21 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5374.1485030921.1@sss.pgh.pa.us> Date: Sat, 21 Jan 2017 15:35:21 -0500 Message-ID: <5375.1485030921@sss.pgh.pa.us> X-Pg-Spam-Score: -5.1 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org David Bowen writes: > If the intent of the test is to compare strings, you should be using ne not > !=. Sure. We were just confused as to how it had ever appeared to work. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers