Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gCrgQ-0001Sp-3q
	for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Oct 2018 19:40:42 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gCrgO-00019s-3v
	for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Oct 2018 19:40:40 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gCrgN-00019M-Pc
	for pgsql-hackers@lists.postgresql.org; Wed, 17 Oct 2018 19:40:39 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gCrg7-00030Q-BN
	for pgsql-hackers@postgresql.org; Wed, 17 Oct 2018 19:40:38 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w9HJeGMD005376;
	Wed, 17 Oct 2018 15:40:16 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@enterprisedb.com>
Subject: Re: Large writable variables
In-reply-to: <32621.1539803353@sss.pgh.pa.us>
References: <20181015200754.7y7zfuzsoux2c4ya@alap3.anarazel.de>
 <CA+Tgmobk-6=b2KLRRMUWGNWi9KzKrx=WNszr7DDE+QCuwNyrEQ@mail.gmail.com>
 <20181016193303.hqpduztwt6ufmasm@alap3.anarazel.de>
 <13249.1539733722@sss.pgh.pa.us>
 <20181017183406.ddt3n5dkqbl45l56@alap3.anarazel.de>
 <32621.1539803353@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 17 Oct 2018 15:09:13 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5374.1539805216.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 17 Oct 2018 15:40:16 -0400
Message-ID: <5375.1539805216@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> .data 0000000000001180 datetktbl ./src/interfaces/ecpg/pgtypeslib/dt_co=
mmon.o
>> .data 0000000000000c28 ibmkanji ./src/backend/utils/mb/conversion_procs=
/euc_jp_and_sjis/euc_jp_and_sjis.o
>> .data 00000000000003f0 deltatktbl ./src/interfaces/ecpg/pgtypeslib/dt_c=
ommon.o

> Hmm.  I think these can just be marked const, will investigate.

I pushed fixes for these, but curiously, the ibmkanji change did not
make any difference to section sizes --- AFAICT, my toolchain already
figured out that it could treat that table as const.  The dt_common.c
changes are a win though.

			regards, tom lane