Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WlDcW-0006aV-7k for pgsql-hackers@arkaria.postgresql.org; Fri, 16 May 2014 08:36:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1WlDcV-0004JZ-LZ for pgsql-hackers@arkaria.postgresql.org; Fri, 16 May 2014 08:35:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WlDcU-0004JP-JQ for pgsql-hackers@postgreSQL.org; Fri, 16 May 2014 08:35:58 +0000 Received: from smtp-outbound-1.vmware.com ([208.91.2.12]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WlDcQ-0002pR-Ia for pgsql-hackers@postgreSQL.org; Fri, 16 May 2014 08:35:58 +0000 Received: from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com [10.113.161.71]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id C54A22879A; Fri, 16 May 2014 01:35:50 -0700 (PDT) Received: from zcs-prod-ext-mta-1.vmware.com (zcs-prod-ext-mta-1.vmware.com [10.113.62.223]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id C1BF019014; Fri, 16 May 2014 01:35:50 -0700 (PDT) Received: from zcs-prod-ext-mta-1.vmware.com (localhost.localdomain [127.0.0.1]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTP id 2E03712002A; Fri, 16 May 2014 01:35:57 -0700 (PDT) Received: from [192.168.1.90] (zimbra-prod-ext-proxy-vip.vmware.com [10.113.63.87]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTPSA; Fri, 16 May 2014 01:35:56 -0700 (PDT) Message-ID: <5375CDE4.5050200@vmware.com> Date: Fri, 16 May 2014 11:35:48 +0300 From: Heikki Linnakangas Organization: VMware User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: Andres Freund CC: PostgreSQL-development Subject: Re: Logical replication woes References: <5374F1FF.9000902@vmware.com> <5374F44B.1060003@vmware.com> <20140515174657.GI23662@alap3.anarazel.de> <537515ED.5060106@vmware.com> <20140515205820.GE16014@awork2.anarazel.de> In-Reply-To: <20140515205820.GE16014@awork2.anarazel.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -7.6 (-------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/15/2014 11:58 PM, Andres Freund wrote: > On 2014-05-15 22:30:53 +0300, Heikki Linnakangas wrote: >>> Attached patch fixes things, but I want to add some regression tests >>> before commit. >> >> Looks good to me. > > Attached are two patches. One for the unitialized dbId/tsId issue; one > for the decoding bug. The former should be backpatched. Thanks, committed. > Should you wonder about the slight reordering of the assignments in > RecordTransactionCommitPrepared() - I've made it more similar to RecordTransactionCommit() > to make it easier to see they are equivalent. Makes sense. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers