Message-ID: <5377fe8f-d8ae-bc15-dcfa-d06cc50d2c03@dunslane.net>
Date: Fri, 10 Dec 2021 19:06:08 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: A test for replay of regression tests
Content-Language: en-US
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>,
 Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CA+hUKGKpRWQ9SxdxxDmTBCJoR0YnFpMBe7kyzY8SUQk+Heskxg@mail.gmail.com>
 <1442880.1619197995@sss.pgh.pa.us>
 <20210423172249.wxzzn3oi35e2bocb@alap3.anarazel.de>
 <CA+hUKGKV=41jk78E_tcHp4m3ab77_gPgbLuE4=WADbmEj4ETTA@mail.gmail.com>
 <CAP4vRV6K0VszoXAAC9f_B9JjZn+3V6bruiqFw=xNVZW-CGn1Aw@mail.gmail.com>
 <CAP4vRV7HP+9D4UT4XCYBhiKmAACYLuKdxMON0o7TTMhe-QsG-w@mail.gmail.com>
 <CA+hUKGKwH-mDeReafALoR5Ui5MVM_HKjyskbkMh+U=6oKk+E3w@mail.gmail.com>
 <CA+hUKG+stUD8qE6s5uJPpFaTW-5ZADp+Bq2Bhiu+-00j3xz7gg@mail.gmail.com>
 <CA+hUKGK=FdtCWjx5eqJ8DVtOoAT2W9os+DYNT3Z9MjX-iaa8zA@mail.gmail.com>
 <1f2ea615-2c26-633d-5018-19e4315f84d3@dunslane.net>
 <e05b213c-1257-84d4-f079-5c4d8c79e3ad@dunslane.net>
 <CA+hUKG+nk_WCqi_y+9TentqwXvy=1dW0DgBB-8yTtgdTTLtP0Q@mail.gmail.com>
 <3e9d1044-ddb2-91a4-917b-8cab3ea93b69@dunslane.net>
 <CA+hUKGLnJoeSqtp0tNyFj2GUYaNgbCQ3KTZqCfFH7QY2+Ojcdg@mail.gmail.com>
 <be82d8ae-2d28-4c79-db4d-4100a644f8c1@dunslane.net>
 <CA+hUKG+C2Uipd8Jw=KACzV1FLMNPsCSrkhFcyGqE7riCnWKPjw@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: 
 <CA+hUKG+C2Uipd8Jw=KACzV1FLMNPsCSrkhFcyGqE7riCnWKPjw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/5377fe8f-d8ae-bc15-dcfa-d06cc50d2c03%40dunslane.net>
Precedence: bulk


On 12/9/21 15:15, Thomas Munro wrote:
> On Fri, Dec 10, 2021 at 2:12 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> The new version appears to set an empty --bindir for pg_regress. Is that
>> right?
> It seems to be necessary to find eg psql, since --bindir='' means
> "expect $PATH to contain the installed binaries", and that's working
> on both build systems.  The alternative would be to export yet another
> environment variable, $PG_INSTALL or such -- do you think that'd be
> better, or did I miss something that exists already like that?


No, that seems ok. Might be worth a comment.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com