pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
doc: mention pg_reload_conf() in pg_hba.conf documentation
3+ messages / 2 participants
[nested] [flat]

Commits from this thread:
  2019-07-16 c6bce6ebb6 d116ebca6c c83067d7ea 63d1bc04d1 1944a253b3 5dbe666ff8 f68060cadb  doc:  mention pg_reload_conf() for reloading the config file
* doc: mention pg_reload_conf() in pg_hba.conf documentation
@ 2019-07-15 03:47 Ian Barwick <ian.barwick@2ndquadrant.com>
  2019-07-16 01:09 ` Re: doc: mention pg_reload_conf() in pg_hba.conf documentation Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 3+ messages in thread

From: Ian Barwick @ 2019-07-15 03:47 UTC (permalink / raw)
  To: pgsql-hackers

Hi

I noticed the documentation for pg_hba.conf:

   https://www.postgresql.org/docs/current/auth-pg-hba-conf.html

says:

     you will need to signal the postmaster (using pg_ctl reload or kill -HUP) to
     make it re-read the file.

It would be useful to mention pg_reload_conf() as another option here, as done
elsewhere in the docs.

Patch with suggested change attached.


Regards

Ian Barwick


-- 
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

doc-pg_hba-pg_reload_conf.v1.patch (text/x-patch, 997B) download diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml new file mode 100644 index 3ed74d8..c90ca0b *** a/doc/src/sgml/client-auth.sgml --- b/doc/src/sgml/client-auth.sgml *************** hostnogssenc <replaceable>database</repl *** 650,657 **** <systemitem>SIGHUP</systemitem><indexterm><primary>SIGHUP</primary></indexterm> signal. If you edit the file on an active system, you will need to signal the postmaster ! (using <literal>pg_ctl reload</literal> or <literal>kill -HUP</literal>) to make it ! re-read the file. </para> <note> --- 650,658 ---- <systemitem>SIGHUP</systemitem><indexterm><primary>SIGHUP</primary></indexterm> signal. If you edit the file on an active system, you will need to signal the postmaster ! (using <literal>pg_ctl reload</literal>, <literal>kill -HUP</literal> ! or by calling the SQL function <function>pg_reload_conf()</function>) ! to make it re-read the file. </para> <note>
^ permalink raw reply [nested|flat] 3+ messages in thread

* Re: doc: mention pg_reload_conf() in pg_hba.conf documentation
  2019-07-15 03:47 doc: mention pg_reload_conf() in pg_hba.conf documentation Ian Barwick <ian.barwick@2ndquadrant.com>
@ 2019-07-16 01:09 ` Bruce Momjian <bruce@momjian.us>
  2019-07-16 04:17   ` Re: doc: mention pg_reload_conf() in pg_hba.conf documentation Ian Barwick <ian.barwick@2ndquadrant.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Bruce Momjian @ 2019-07-16 01:09 UTC (permalink / raw)
  To: Ian Barwick <ian.barwick@2ndquadrant.com>; +Cc: pgsql-hackers

On Mon, Jul 15, 2019 at 12:47:18PM +0900, Ian Barwick wrote:
> Hi
> 
> I noticed the documentation for pg_hba.conf:
> 
>   https://www.postgresql.org/docs/current/auth-pg-hba-conf.html
> 
> says:
> 
>     you will need to signal the postmaster (using pg_ctl reload or kill -HUP) to
>     make it re-read the file.
> 
> It would be useful to mention pg_reload_conf() as another option here, as done
> elsewhere in the docs.
> 
> Patch with suggested change attached.

Oh, good point.  Not sure how we missed that, but I had to fix a mention
in pg_hba.conf a while ago too.  Also, there were two mentions in that
file, so I fixed them both with the attached patch.  Backpatched to 9.4.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

Attachments:

1 (text/plain, 1.8K) download diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml new file mode 100644 index 3ed74d8..fada728 *** a/doc/src/sgml/client-auth.sgml --- b/doc/src/sgml/client-auth.sgml *************** hostnogssenc <replaceable>database</repl *** 650,657 **** <systemitem>SIGHUP</systemitem><indexterm><primary>SIGHUP</primary></indexterm> signal. If you edit the file on an active system, you will need to signal the postmaster ! (using <literal>pg_ctl reload</literal> or <literal>kill -HUP</literal>) to make it ! re-read the file. </para> <note> --- 650,658 ---- <systemitem>SIGHUP</systemitem><indexterm><primary>SIGHUP</primary></indexterm> signal. If you edit the file on an active system, you will need to signal the postmaster ! (using <literal>pg_ctl reload</literal>, calling the SQL function ! <function>pg_reload_conf()</function>, or using <literal>kill ! -HUP</literal>) to make it re-read the file. </para> <note> *************** mymap /^(.*)@otherdomain\.com$ guest *** 871,878 **** <systemitem>SIGHUP</systemitem><indexterm><primary>SIGHUP</primary></indexterm> signal. If you edit the file on an active system, you will need to signal the postmaster ! (using <literal>pg_ctl reload</literal> or <literal>kill -HUP</literal>) to make it ! re-read the file. </para> <para> --- 872,880 ---- <systemitem>SIGHUP</systemitem><indexterm><primary>SIGHUP</primary></indexterm> signal. If you edit the file on an active system, you will need to signal the postmaster ! (using <literal>pg_ctl reload</literal>, calling the SQL function ! <function>pg_reload_conf()</function>, or using <literal>kill ! -HUP</literal>) to make it re-read the file. </para> <para>
^ permalink raw reply [nested|flat] 3+ messages in thread

* Re: doc: mention pg_reload_conf() in pg_hba.conf documentation
  2019-07-15 03:47 doc: mention pg_reload_conf() in pg_hba.conf documentation Ian Barwick <ian.barwick@2ndquadrant.com>
  2019-07-16 01:09 ` Re: doc: mention pg_reload_conf() in pg_hba.conf documentation Bruce Momjian <bruce@momjian.us>
@ 2019-07-16 04:17   ` Ian Barwick <ian.barwick@2ndquadrant.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Ian Barwick @ 2019-07-16 04:17 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-hackers

On 7/16/19 10:09 AM, Bruce Momjian wrote:
> On Mon, Jul 15, 2019 at 12:47:18PM +0900, Ian Barwick wrote:
>> Hi
>>
>> I noticed the documentation for pg_hba.conf:
>>
>>    https://www.postgresql.org/docs/current/auth-pg-hba-conf.html
>>
>> says:
>>
>>      you will need to signal the postmaster (using pg_ctl reload or kill -HUP) to
>>      make it re-read the file.
>>
>> It would be useful to mention pg_reload_conf() as another option here, as done
>> elsewhere in the docs.
>>
>> Patch with suggested change attached.
> 
> Oh, good point.  Not sure how we missed that, but I had to fix a mention
> in pg_hba.conf a while ago too.  Also, there were two mentions in that
> file, so I fixed them both with the attached patch.  Backpatched to 9.4.

Thanks!

I only noticed it because I was writing up some basic instructions for someone
not very familiar with Pg, and cross-referencing to the documentation.


Regards

Ian Barwick


-- 
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services





^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2019-07-16 04:17 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 03:47 doc: mention pg_reload_conf() in pg_hba.conf documentation Ian Barwick <ian.barwick@2ndquadrant.com>
2019-07-16 01:09 ` Bruce Momjian <bruce@momjian.us>
2019-07-16 04:17   ` Ian Barwick <ian.barwick@2ndquadrant.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox