Message-ID: <53AB424D.8030306@vmware.com>
Date: Thu, 26 Jun 2014 00:42:37 +0300
From: Heikki Linnakangas <hlinnakangas@vmware.com>
Organization: VMware
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: Andres Freund <andres@2ndquadrant.com>,
 Robert Haas <robertmhaas@gmail.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@heroku.com>, Pg Hackers
 <pgsql-hackers@postgresql.org>, Ants Aasma <ants@cybertec.at>
Subject: Re: better atomics - v0.5
References: 
 <CA+TgmoYBW+ux5-8Ja=Mcyuy8=VXAnVRHp3Kess6Pn3DMXAPAEA@mail.gmail.com>
 <20140625171434.GG24114@awork2.anarazel.de>
 <CA+TgmoZShVVqjaKUL6P3kDvZVPibtgkzoti3M+Fvvjg5V+XJ0A@mail.gmail.com>
 <20140625203635.GJ24114@awork2.anarazel.de>
In-Reply-To: <20140625203635.GJ24114@awork2.anarazel.de>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 06/25/2014 11:36 PM, Andres Freund wrote:
>
>> >- I completely loathe the file layout you've proposed in
>> >src/include/storage.  If we're going to have separate #include files
>> >for each architecture (and I'd rather we didn't go that route, because
>> >it's messy and unlike what we have now), then shouldn't that stuff go
>> >in src/include/port or a new directory src/include/port/atomics?
>> >Polluting src/include/storage with a whole bunch of files called
>> >atomics-whatever.h strikes me as completely ugly, and there's a lot of
>> >duplicate code in there.
> I don't mind moving it somewhere else and it's easy enough to change.

I think having a separate file for each architecture is nice. I totally 
agree that they don't belong in src/include/storage, though. s_lock.h 
has always been misplaced there, but we've let it be for historical 
reasons, but now that we're adding a dozen new files, it's time to move 
them out.

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers