Message-ID: <53B2188B.4090302@lab.ntt.co.jp>
Date: Tue, 01 Jul 2014 11:10:19 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.0;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
 Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
 Shigeru Hanada <shigeru.hanada@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: inherit support for foreign tables
References: <53393E18.3080901@lab.ntt.co.jp> <533C01C7.6030809@lab.ntt.co.jp>
 <53706FB6.6000403@lab.ntt.co.jp>
 <20140620.170406.123403564.horiguchi.kyotaro@lab.ntt.co.jp>
 <CAFjFpRcG03b3UZSXTKmro+72qYTdBfxoWCaEMgZBxY1QKyJrbQ@mail.gmail.com>
 <53A92924.90702@lab.ntt.co.jp> <53B10914.2010504@lab.ntt.co.jp>
 <3492.1404136084@sss.pgh.pa.us>
In-Reply-To: <3492.1404136084@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

(2014/06/30 22:48), Tom Lane wrote:
> Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> writes:
>> Done.  I think this is because create_foreignscan_plan() makes reference
>> to attr_needed, which isn't computed for inheritance children.
> 
> I wonder whether it isn't time to change that.  It was coded like that
> originally only because calculating the values would've been a waste of
> cycles at the time.  But this is at least the third place where it'd be
> useful to have attr_needed for child rels.

+1 for calculating attr_needed for child rels.  (I was wondering too.)

I'll create a separate patch for it.

Thanks,

Best regards,
Etsuro Fujita


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers