public inbox for [email protected]  

help / color / mirror / Atom feed
From: 曾文旌 <[email protected]>
To: Prabhat Sahu <[email protected]>
Cc: Pavel Stehule <[email protected]>
Cc: tushar <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Konstantin Knizhnik <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: "蔡松露(子嘉)" <[email protected]>
Cc: Cai, Le <[email protected]>
Subject: Re: [Proposal] Global temporary tables
Date: Thu, 11 Jun 2020 10:13:08 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANEvxPp-7yEBxD=N+HnRhPP+8wKUYmXgvQPxf445hphyQaH8ww@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CANEvxPrEAtmWN6z8T3ed81V5WZBxfrQ2LmHO1uOEOeUBh83Z-Q@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CANEvxPpfTrNGXw2K3MzFMt6NGBAQwLXbv6SHJ_XBEfqEimJxJA@mail.gmail.com>
	<[email protected]>
	<CANEvxPrVan7f_JgVr5chaOHGtMHFfL-A5hVcYbQj_-5aYWvDRQ@mail.gmail.com>
	<[email protected]>
	<CANEvxPpAxb30mnWdp4YZvwFF28A3zf3LCuEg91BE1djRTYSZcg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CANEvxPoKNoddQ6UYOgXkGSZuc30KVZODySJu1E=a8hs1P7PPgA@mail.gmail.com>
	<[email protected]>
	<CANEvxPp1f1vN3ht6Bww=3yqGi46hUPVaiv8WWZwVMvWvGacVHg@mail.gmail.com>
	<CANEvxPqu2uiNW8r_ZY1iZLe6PwsJ59BY_6YqVRxmGUyUK=v=AA@mail.gmail.com>
	<CANEvxPrSOM26cGnTerCz-pJnNewroqJnw2BF97=BDmz6c+Rn8Q@mail.gmail.com>
	<[email protected]>
	<CAFj8pRCyE4iCp3s8JadPfFQNoZUv-MyMC4HtaxCpS6kiMyJbVA@mail.gmail.com>
	<[email protected]>
	<CANEvxPqetpWNzWgbeZw9RMJQRJhBH7A8Kx8DhsKrDcZEm6Ps4A@mail.gmail.com>
	<CAFj8pRDN2D3dK-+jbav_PdrWuSXX+Ld2kXoT-ZJa_nirqtLzxw@mail.gmail.com>
	<[email protected]>
	<CAFj8pRDVURvQBZhGeUEBBTaqnjfK3w7u+xZfAqVB+-ncUezFZA@mail.gmail.com>
	<[email protected]>
	<CANEvxPooq5GyoHVCw6LSjE5Ntxg+RkjBvyM_8-bJhUHmdsDG7w@mail.gmail.com>
	<[email protected]>
	<CANEvxPoWTnWvLeXsjPiCmEsUZpCgv8aQ7FU1DVoW2i49+8m5+g@mail.gmail.com>
	<[email protected]>
	<CANEvxPp-7yEBxD=N+HnRhPP+8wKUYmXgvQPxf445hphyQaH8ww@mail.gmail.com>


> 2020年6月9日 下午8:15，Prabhat Sahu <[email protected]> 写道：
> 
> 
> 
> On Wed, Apr 29, 2020 at 8:52 AM 曾文旌 <[email protected] <mailto:[email protected]>> wrote:
>> 2020年4月27日 下午9:48，Prabhat Sahu <[email protected] <mailto:[email protected]>> 写道：
>> 
>> Thanks Wenjing, for the fix patch for previous issues.
>> I have verified the issues, now those fix look good to me.
>> But the below error message is confusing(for gtt2).
>> 
>> postgres=# drop table gtt1;
>> ERROR:  cannot drop global temp table gtt1 when other backend attached it.
>> 
>> postgres=# drop table gtt2;
>> ERROR:  cannot drop index idx2 on global temp table gtt2 when other backend attached it.
>> 
>> I feel the above error message shown for "DROP TABLE gtt2;" is a bit confusing(looks similar to DROP INDEX gtt2;).
>> If possible, can we keep the error message simple as "ERROR:  cannot drop global temp table gtt2 when other backend attached it."?
>> I mean, without giving extra information for the index attached to that GTT.
> Fixed the error message to make the expression more accurate. In v33.
>  
> Thanks Wenjing. We verified your latest patch(gtt_v33) focusing on all reported issues and they work fine. 
> Thanks.
> -- 

I'm very glad to hear such good news.
I am especially grateful for your professional work on GTT.
Please feel free to let me know if there is anything you think could be improved.


Thanks.


Wenjing

> With Regards,
> Prabhat Kumar Sahu
> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/;



Attachments:

  [application/pkcs7-signature] smime.p7s (2.3K, ../[email protected]/3-smime.p7s)
  download

view thread (492+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Proposal] Global temporary tables
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox