Message-ID: <53b1274b-454e-6c89-1864-0df6ead5af1b@enterprisedb.com>
Date: Sun, 2 Jul 2023 20:13:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: Memory leak in incremental sort re-scan
Content-Language: en-US
To: Laurenz Albe <laurenz.albe@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
References: <b2bd02dff61af15e3526293e2771f874cf2a3be7.camel@cybertec.at>
 <99e584a1-2f55-a56d-efb1-d38c57eb2beb@enterprisedb.com>
 <2267955.1686859883@sss.pgh.pa.us>
 <0643dbc2-53a6-37ac-b567-243a489cef0f@enterprisedb.com>
 <2275724.1686861393@sss.pgh.pa.us>
 <c4df75a8-b274-9a65-8815-74de587865b7@enterprisedb.com>
 <1eeeebf37fda63cf0946e9b77e5bd6a8ac827615.camel@cybertec.at>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <1eeeebf37fda63cf0946e9b77e5bd6a8ac827615.camel@cybertec.at>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/53b1274b-454e-6c89-1864-0df6ead5af1b%40enterprisedb.com>
Precedence: bulk


On 6/29/23 13:49, Laurenz Albe wrote:
> On Fri, 2023-06-16 at 00:34 +0200, Tomas Vondra wrote:
>> On 6/15/23 22:36, Tom Lane wrote:
>>> Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
>>>> On 6/15/23 22:11, Tom Lane wrote:
>>>>> I see zero leakage in that example after applying the attached quick
>>>>> hack.  (It might be better to make the check in the caller, or to just
>>>>> move the call to ExecInitIncrementalSort.)
>>>
>>>> Thanks for looking. Are you planning to work on this and push the fix,
>>>> or do you want me to finish this up?
>>>
>>> I'm happy to let you take it -- got lots of other stuff on my plate.
>>
>> OK, will do.
> 
> It would be cool if we could get that into the next minor release in August.
> 

FWIW I've pushed the fix prepared by James a couple days ago. Thanks for
the report!


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company