User-Agent: Cyrus-JMAP/3.5.0-alpha0-4524-g5e5d2efdba-fm-20211214.001-g5e5d2efd
Mime-Version: 1.0
Message-Id: <53e4a0d4-4b7b-4001-99c3-576bc03f73ef@www.fastmail.com>
In-Reply-To: <YcBkyHOBwSljDkCZ@paquier.xyz>
References: 
 <OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAExHW5uWwcV0-=JQXYhEpnEtmwmZQsh0c1N3cxxBYRhwE9WuvQ@mail.gmail.com>
 <Yblf/R3h0Dj+Ui2v@paquier.xyz>
 <OS3PR01MB6275A10D03572E27C4E2C9769E769@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <YbpuuHqAkf2hjOA0@paquier.xyz>
 <OS3PR01MB62750A124D384B4E96CA43F19E779@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <OS3PR01MB62750A0A1A282E9E0148172B9E7B9@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <YcBkyHOBwSljDkCZ@paquier.xyz>
Date: Mon, 20 Dec 2021 11:57:32 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Michael Paquier" <michael@paquier.xyz>,
 "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Cc: "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Confused comment about drop replica identity index
Content-Type: multipart/mixed;
 boundary=421e7ead858f48058c1a27e5d9bee5fb
Archived-At: 
 <https://www.postgresql.org/message-id/53e4a0d4-4b7b-4001-99c3-576bc03f73ef%40www.fastmail.com>
Precedence: bulk

--421e7ead858f48058c1a27e5d9bee5fb
Content-Type: multipart/alternative;
 boundary=0eeceefb1ac5468eaaa92b5e17113583

--0eeceefb1ac5468eaaa92b5e17113583
Content-Type: text/plain

On Mon, Dec 20, 2021, at 8:11 AM, Michael Paquier wrote:
> On Mon, Dec 20, 2021 at 03:46:13AM +0000, wangw.fnst@fujitsu.com wrote:
> > Here is a patch to correct wrong comment about
> > REPLICA_IDENTITY_INDEX, And improve the pg-doc.
> 
> That's mostly fine.  I have made some adjustments as per the
> attached.
Your patch looks good to me.

> Pondering more about this thread, I don't think we should change the
> existing behavior in the back-branches, but I don't have any arguments
> about doing such changes on HEAD to help the features being worked
> on, either.  So I'd like to apply and back-patch the attached, as a
> first step, to fix the inconsistency.
> 
What do you think about the attached patch? It forbids the DROP INDEX. We might
add a detail message but I didn't in this patch.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--0eeceefb1ac5468eaaa92b5e17113583
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Dec 20,=
 2021, at 8:11 AM, Michael Paquier wrote:<br></div><blockquote type=3D"c=
ite" id=3D"qt" style=3D""><div>On Mon, Dec 20, 2021 at 03:46:13AM +0000,=
&nbsp;<a href=3D"mailto:wangw.fnst@fujitsu.com">wangw.fnst@fujitsu.com</=
a> wrote:<br></div><div>&gt; Here is a patch to correct wrong comment ab=
out<br></div><div>&gt; REPLICA_IDENTITY_INDEX, And improve the pg-doc.<b=
r></div><div><br></div><div>That's mostly fine.&nbsp; I have made some a=
djustments as per the<br></div><div>attached.<br></div></blockquote><div=
>Your patch looks good to me.<br></div><div><br></div><blockquote type=3D=
"cite" id=3D"qt" style=3D""><div>Pondering more about this thread, I don=
't think we should change the<br></div><div>existing behavior in the bac=
k-branches, but I don't have any arguments<br></div><div>about doing suc=
h changes on HEAD to help the features being worked<br></div><div>on, ei=
ther.&nbsp; So I'd like to apply and back-patch the attached, as a<br></=
div><div>first step, to fix the inconsistency.<br></div><div><br></div><=
/blockquote><div>What do you think about the attached patch? It forbids =
the DROP INDEX. We might<br></div><div>add a detail message but I didn't=
 in this patch.<br></div><div><br></div><div><br></div><div id=3D"sig112=
409080"><div class=3D"signature">--<br></div><div class=3D"signature">Eu=
ler Taveira<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D=
"https://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></d=
iv></div><div><br></div></body></html>
--0eeceefb1ac5468eaaa92b5e17113583--

--421e7ead858f48058c1a27e5d9bee5fb
Content-Disposition: 
 attachment;filename="v1-0001-Disallow-dropping-an-index-that-is-used-by-replic.patch"
Content-Type: text/x-patch;
 name="v1-0001-Disallow-dropping-an-index-that-is-used-by-replic.patch"
Content-Transfer-Encoding: BASE64

RnJvbSAyYmEwMDMzNTc0NmNmODM0OGUwMTk1ODJhMjUzNzIxMDQ3ZjFhMGFjIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFdWxlciBUYXZlaXJhIDxldWxlci50YXZlaXJhQGVu
dGVycHJpc2VkYi5jb20+CkRhdGU6IFRodSwgMTYgRGVjIDIwMjEgMTY6NTQ6NDcgLTAzMDAK
U3ViamVjdDogW1BBVENIIHYxXSBEaXNhbGxvdyBkcm9wcGluZyBhbiBpbmRleCB0aGF0IGlz
IHVzZWQgYnkgcmVwbGljYQogaWRlbnRpdHkKCkRyb3AgYW4gaW5kZXggdGhhdCBpcyB1c2Vk
IGJ5IGEgcmVwbGljYSBpZGVudGl0eSBjYW4gYnJlYWsgdGhlCnJlcGxpY2F0aW9uIGZvciBV
UERBVEUgYW5kIERFTEVURSBvcGVyYXRpb25zLiBUaGlzIG1heSBiZSB1bmRlc2lyYWJsZQpm
cm9tIHRoZSB1c2FiaWxpdHkgc3RhbmRwb2ludC4gSXQgaW50cm9kdWNlcyBhIGJlaGF2aW91
ciBjaGFuZ2UuCi0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMgICAgICAg
ICAgICAgICB8IDE0ICsrKysrKysrKysrKystCiBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVk
L3JlcGxpY2FfaWRlbnRpdHkub3V0IHwgIDMgKysrCiBzcmMvdGVzdC9yZWdyZXNzL3NxbC9y
ZXBsaWNhX2lkZW50aXR5LnNxbCAgICAgIHwgIDMgKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE5
IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2Vu
ZC9jb21tYW5kcy90YWJsZWNtZHMuYyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21k
cy5jCmluZGV4IGJmNDI1ODdlMzguLjcyN2FkNjYyNWIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNr
ZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jCisrKyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3Rh
YmxlY21kcy5jCkBAIC0xNTMwLDE1ICsxNTMwLDIxIEBAIFJhbmdlVmFyQ2FsbGJhY2tGb3JE
cm9wUmVsYXRpb24oY29uc3QgUmFuZ2VWYXIgKnJlbCwgT2lkIHJlbE9pZCwgT2lkIG9sZFJl
bE9pZCwKIAkJCQkJICAgcmVsLT5yZWxuYW1lKTsKIAogCS8qCisJICogQW4gaW5kZXggdXNl
ZCBieSBhIHJlcGxpY2EgaWRlbnRpdHkgY2Fubm90IGJlIGRyb3BwZWQgYmVjYXVzZSBzb21l
CisJICogb3BlcmF0aW9ucyAoVVBEQVRFIGFuZCBERUxFVEUpIHJlbGllcyBvbiB0aGUgaW5k
ZXggcHJvcGVydGllcworCSAqICh1bmlxdWVuZXNzIGFuZCBOT1QgTlVMTCkgdG8gcmVjb3Jk
IG9sZCB2YWx1ZXMuIFRoZXNlIG9sZCB2YWx1ZXMgYXJlCisJICogZXNzZW50aWFsIGZvciBp
ZGVudGlmeWluZyB0aGUgcm93IG9uIHRoZSBzdWJzY3JpYmVyLgorCSAqCiAJICogQ2hlY2sg
dGhlIGNhc2Ugb2YgYSBzeXN0ZW0gaW5kZXggdGhhdCBtaWdodCBoYXZlIGJlZW4gaW52YWxp
ZGF0ZWQgYnkgYQogCSAqIGZhaWxlZCBjb25jdXJyZW50IHByb2Nlc3MgYW5kIGFsbG93IGl0
cyBkcm9wLiBGb3IgdGhlIHRpbWUgYmVpbmcsIHRoaXMKIAkgKiBvbmx5IGNvbmNlcm5zIGlu
ZGV4ZXMgb2YgdG9hc3QgcmVsYXRpb25zIHRoYXQgYmVjYW1lIGludmFsaWQgZHVyaW5nIGEK
IAkgKiBSRUlOREVYIENPTkNVUlJFTlRMWSBwcm9jZXNzLgogCSAqLwotCWlmIChJc1N5c3Rl
bUNsYXNzKHJlbE9pZCwgY2xhc3Nmb3JtKSAmJiByZWxraW5kID09IFJFTEtJTkRfSU5ERVgp
CisJaWYgKHJlbGtpbmQgPT0gUkVMS0lORF9JTkRFWCkKIAl7CiAJCUhlYXBUdXBsZQlsb2NU
dXBsZTsKIAkJRm9ybV9wZ19pbmRleCBpbmRleGZvcm07CisJCWJvb2wJCWluZGlzcmVwbGlk
ZW50OwogCQlib29sCQlpbmRpc3ZhbGlkOwogCiAJCWxvY1R1cGxlID0gU2VhcmNoU3lzQ2Fj
aGUxKElOREVYUkVMSUQsIE9iamVjdElkR2V0RGF0dW0ocmVsT2lkKSk7CkBAIC0xNTUwLDgg
KzE1NTYsMTQgQEAgUmFuZ2VWYXJDYWxsYmFja0ZvckRyb3BSZWxhdGlvbihjb25zdCBSYW5n
ZVZhciAqcmVsLCBPaWQgcmVsT2lkLCBPaWQgb2xkUmVsT2lkLAogCiAJCWluZGV4Zm9ybSA9
IChGb3JtX3BnX2luZGV4KSBHRVRTVFJVQ1QobG9jVHVwbGUpOwogCQlpbmRpc3ZhbGlkID0g
aW5kZXhmb3JtLT5pbmRpc3ZhbGlkOworCQlpbmRpc3JlcGxpZGVudCA9IGluZGV4Zm9ybS0+
aW5kaXNyZXBsaWRlbnQ7CiAJCVJlbGVhc2VTeXNDYWNoZShsb2NUdXBsZSk7CiAKKwkJaWYg
KGluZGlzcmVwbGlkZW50KQorCQkJZXJlcG9ydChFUlJPUiwKKwkJCQkJKGVycmNvZGUoRVJS
Q09ERV9JTlZBTElEX1RBQkxFX0RFRklOSVRJT04pLAorCQkJCQkgZXJybXNnKCJjb3VsZCBu
b3QgZHJvcCBpbmRleCBcIiVzXCIgYmVjYXVzZSBpdCBpcyByZXF1aXJlZCBieSB0aGUgcmVw
bGljYSBpZGVudGl0eSIsIHJlbC0+cmVsbmFtZSkpKTsKKwogCQkvKiBNYXJrIG9iamVjdCBh
cyBiZWluZyBhbiBpbnZhbGlkIGluZGV4IG9mIHN5c3RlbSBjYXRhbG9ncyAqLwogCQlpZiAo
IWluZGlzdmFsaWQpCiAJCQlpbnZhbGlkX3N5c3RlbV9pbmRleCA9IHRydWU7CmRpZmYgLS1n
aXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3JlcGxpY2FfaWRlbnRpdHkub3V0IGIv
c3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9yZXBsaWNhX2lkZW50aXR5Lm91dAppbmRleCBl
MjVlYzA2YTg0Li41NjkwMDQ1MWY3IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4
cGVjdGVkL3JlcGxpY2FfaWRlbnRpdHkub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhw
ZWN0ZWQvcmVwbGljYV9pZGVudGl0eS5vdXQKQEAgLTIyNyw2ICsyMjcsOSBAQCBJbmRleGVz
OgogLS0gdXNlZCBhcyByZXBsaWNhIGlkZW50aXR5LgogQUxURVIgVEFCTEUgdGVzdF9yZXBs
aWNhX2lkZW50aXR5MyBBTFRFUiBDT0xVTU4gaWQgRFJPUCBOT1QgTlVMTDsKIEVSUk9SOiAg
Y29sdW1uICJpZCIgaXMgaW4gaW5kZXggdXNlZCBhcyByZXBsaWNhIGlkZW50aXR5CistLSBE
Uk9QIElOREVYIGlzIG5vdCBhbGxvd2VkIGlmIHRoZSBpbmRleCBpcyB1c2VkIGFzIFJFUExJ
Q0EgSURFTlRJVFkKK0RST1AgSU5ERVggdGVzdF9yZXBsaWNhX2lkZW50aXR5M19pZF9rZXk7
CitFUlJPUjogIGNvdWxkIG5vdCBkcm9wIGluZGV4ICJ0ZXN0X3JlcGxpY2FfaWRlbnRpdHkz
X2lkX2tleSIgYmVjYXVzZSBpdCBpcyByZXF1aXJlZCBieSB0aGUgcmVwbGljYSBpZGVudGl0
eQogRFJPUCBUQUJMRSB0ZXN0X3JlcGxpY2FfaWRlbnRpdHk7CiBEUk9QIFRBQkxFIHRlc3Rf
cmVwbGljYV9pZGVudGl0eTI7CiBEUk9QIFRBQkxFIHRlc3RfcmVwbGljYV9pZGVudGl0eTM7
CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9yZXBsaWNhX2lkZW50aXR5LnNx
bCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3JlcGxpY2FfaWRlbnRpdHkuc3FsCmluZGV4IDMz
ZGE4Mjk3MTMuLmY0Njc2OWU5NjUgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3Fs
L3JlcGxpY2FfaWRlbnRpdHkuc3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3JlcGxp
Y2FfaWRlbnRpdHkuc3FsCkBAIC05OCw2ICs5OCw5IEBAIEFMVEVSIFRBQkxFIHRlc3RfcmVw
bGljYV9pZGVudGl0eTMgQUxURVIgQ09MVU1OIGlkIFRZUEUgYmlnaW50OwogLS0gdXNlZCBh
cyByZXBsaWNhIGlkZW50aXR5LgogQUxURVIgVEFCTEUgdGVzdF9yZXBsaWNhX2lkZW50aXR5
MyBBTFRFUiBDT0xVTU4gaWQgRFJPUCBOT1QgTlVMTDsKIAorLS0gRFJPUCBJTkRFWCBpcyBu
b3QgYWxsb3dlZCBpZiB0aGUgaW5kZXggaXMgdXNlZCBhcyBSRVBMSUNBIElERU5USVRZCitE
Uk9QIElOREVYIHRlc3RfcmVwbGljYV9pZGVudGl0eTNfaWRfa2V5OworCiBEUk9QIFRBQkxF
IHRlc3RfcmVwbGljYV9pZGVudGl0eTsKIERST1AgVEFCTEUgdGVzdF9yZXBsaWNhX2lkZW50
aXR5MjsKIERST1AgVEFCTEUgdGVzdF9yZXBsaWNhX2lkZW50aXR5MzsKLS0gCjIuMjAuMQoK

--421e7ead858f48058c1a27e5d9bee5fb--