From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        David Steele <david@pgmasters.net>, Joe Conway <mail@joeconway.com>,
        Magnus Hagander <magnus@hagander.net>,
        Michael Paquier <michael@paquier.xyz>,
        Nico Williams <nico@cryptonector.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Robbie Harwood <rharwood@redhat.com>
Subject: Re: [PATCH v20] GSSAPI encryption support
In-reply-to: 
 <CAOuzzgrztzi+g5vfd-dtNxx+MByZcy9nMVzavYZTgvZGHx98Hg@mail.gmail.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com> <jlgy38mir81.fsf@redhat.com>
 <5ec3f734-810e-36e0-030f-af92efe135da@2ndquadrant.com>
 <20190223162751.GO6197@tamriel.snowman.net>
 <1f799b02-d766-0328-45d6-73e5674d0bc2@2ndquadrant.com>
 <CAOuzzgprZ7-gYkzwkPzMOPka62irppKpXNm219q7a_8Fu33TLw@mail.gmail.com>
 <500b1be7-d0aa-96a2-9982-d748609faff5@joeconway.com>
 <CABUevEyuNNJv=19foa=ycTfTfBUYOEwM8_Uss5OVKrwBAy+Btw@mail.gmail.com>
 <20190403144332.GD6197@tamriel.snowman.net>
 <7b7035e0-3691-ca63-0957-25d17dc11514@2ndquadrant.com>
 <CAOuzzgrztzi+g5vfd-dtNxx+MByZcy9nMVzavYZTgvZGHx98Hg@mail.gmail.com>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Thu, 04 Apr 2019 07:50:33 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <5405.1554388830.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 04 Apr 2019 10:40:30 -0400
Message-ID: <5406.1554388830@sss.pgh.pa.us>
Precedence: bulk

Stephen Frost <sfrost@snowman.net> writes:
> On Thu, Apr 4, 2019 at 05:20 Peter Eisentraut <
> peter.eisentraut@2ndquadrant.com> wrote:
>> Kerberos tests are now failing for me (macOS).

> Interesting, they work locally for me on Ubuntu.  Unfortunately, I don=E2=
=80=99t
> have macOS.  This only happens when encryption is being used, presumably=
?
> GSS authentication is still working fine?

The kerberos test suite passes for me on RHEL6 (kerberos 1.10.3),
but I observe some compiler warnings that need to be dealt with:

$ ./configure --with-gssapi ...
$ time make -j8 -s
be-secure-gssapi.c:597: warning: no previous prototype for 'be_gssapi_get_=
auth'
be-secure-gssapi.c:609: warning: no previous prototype for 'be_gssapi_get_=
enc'
be-secure-gssapi.c:621: warning: no previous prototype for 'be_gssapi_get_=
princ'
pgstat.c: In function 'pgstat_bestart':
pgstat.c:2986: warning: implicit declaration of function 'be_gssapi_get_au=
th'
pgstat.c:2987: warning: implicit declaration of function 'be_gssapi_get_en=
c'
pgstat.c:2990: warning: implicit declaration of function 'be_gssapi_get_pr=
inc'
pgstat.c:2990: warning: passing argument 2 of 'strlcpy' makes pointer from=
 integer without a cast
../../../src/include/port.h:429: note: expected 'const char *' but argumen=
t is of type 'int'
All of PostgreSQL successfully made. Ready to install.

I'm not very sure why the integer/pointer confusion in pgstat_bestart
doesn't cause hard crashes when using gss auth --- or does
this suite not actually test that?

			regards, tom lane