Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XS0ag-0000kO-Pk for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Sep 2014 09:22:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1XS0ag-0004cP-5W for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Sep 2014 09:22:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XS0ae-0004cG-Pa for pgsql-hackers@postgresql.org; Thu, 11 Sep 2014 09:22:56 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XS0aS-0007Kj-6Q for pgsql-hackers@postgresql.org; Thu, 11 Sep 2014 09:22:52 +0000 Received: from mfs6.rdh.ecl.ntt.co.jp (mfs6.rdh.ecl.ntt.co.jp [129.60.39.149]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id s8B9Ma9A032616; Thu, 11 Sep 2014 18:22:36 +0900 Received: from mfs6.rdh.ecl.ntt.co.jp (localhost.localdomain [127.0.0.1]) by mfs6.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id 59A6DE00EB; Thu, 11 Sep 2014 18:22:36 +0900 (JST) Received: from imail3.m.ecl.ntt.co.jp (imail3.m.ecl.ntt.co.jp [129.60.5.248]) by mfs6.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id 4228EE00E6; Thu, 11 Sep 2014 18:22:36 +0900 (JST) Received: from [129.60.241.75] ([129.60.241.75]) by imail3.m.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id s8B9MZbA020515; Thu, 11 Sep 2014 18:22:36 +0900 Message-ID: <541169C3.3030900@lab.ntt.co.jp> Date: Thu, 11 Sep 2014 18:22:11 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Heikki Linnakangas , Kyotaro HORIGUCHI CC: noah@leadboat.com, shigeru.hanada@gmail.com, pgsql-hackers@postgresql.org Subject: Re: inherit support for foreign tables References: <53F48245.6020204@lab.ntt.co.jp> <20140822025137.GA563733@tornado.leadboat.com> <53FEEF94.6040101@lab.ntt.co.jp> <20140902.142218.253402812.horiguchi.kyotaro@lab.ntt.co.jp> <5410A76B.20102@vmware.com> In-Reply-To: <5410A76B.20102@vmware.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Pg-Spam-Score: -4.4 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org (2014/09/11 4:32), Heikki Linnakangas wrote: > I had a cursory look at this patch and the discussions around this. Thank you! > ISTM there are actually two new features in this: 1) allow CHECK > constraints on foreign tables, and 2) support inheritance for foreign > tables. How about splitting it into two? That's right. There are the two in this patch. I'm not sure if I should split the patch into the two, because 1) won't make sense without 2). As described in the following note added to the docs on CREATE FOREIGN TABLE, CHECK constraints on foreign tables are intended to support constraint exclusion for partitioned foreign tables: + Constraints on foreign tables are not enforced on insert or update. + Those definitions simply declare the constraints hold for all rows + in the foreign tables. It is the user's responsibility to ensure + that those definitions match the remote side. Such constraints are + used for some kind of query optimization such as constraint exclusion + for partitioned tables Thanks, Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers