Message-ID: <543F7639.300@lab.ntt.co.jp>
Date: Thu, 16 Oct 2014 16:39:37 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.0;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Noah Misch <noah@leadboat.com>
CC: shigeru.hanada@gmail.com,
 Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
 pgsql-hackers@postgresql.org
Subject: Re: inherit support for foreign tables
References: <53393E18.3080901@lab.ntt.co.jp> <533C01C7.6030809@lab.ntt.co.jp>
 <53706FB6.6000403@lab.ntt.co.jp>
 <20140620.170406.123403564.horiguchi.kyotaro@lab.ntt.co.jp>
 <20140702022327.GC1586927@tornado.leadboat.com>
 <53F48245.6020204@lab.ntt.co.jp>
 <20140822025137.GA563733@tornado.leadboat.com>
 <53FEEF94.6040101@lab.ntt.co.jp>
In-Reply-To: <53FEEF94.6040101@lab.ntt.co.jp>
Content-Type: multipart/mixed; boundary="------------080504040801000502020508"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------080504040801000502020508
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

(2014/08/28 18:00), Etsuro Fujita wrote:
> (2014/08/22 11:51), Noah Misch wrote:
>> Today's ANALYZE VERBOSE messaging for former inheritance parents
>> (tables with
>> relhassubclass = true but no pg_inherits.inhparent links) is
>> deceptive, and I
>> welcome a fix to omit the spurious message.  As defects go, this is quite
>> minor.  There's fundamentally no value in collecting inheritance tree
>> statistics for such a parent, and no PostgreSQL command will do so.

>> A
>> credible alternative is to emit a second message indicating that we
>> skipped
>> the inheritance tree statistics after all, and why we skipped them.

> I'd like to address this by emitting the second message as shown below:

> A separate patch (analyze.patch) handles the former case in a similar way.

I'll add to the upcoming CF, the analyze.patch as an independent item, 
which emits a second message indicating that we skipped the inheritance 
tree statistics and why we skipped them.

Thanks,

Best regards,
Etsuro Fujita

--------------080504040801000502020508
Content-Type: text/x-patch;
 name="analyze.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="analyze.patch"

*** a/src/backend/commands/analyze.c
--- b/src/backend/commands/analyze.c
***************
*** 1478,1483 **** acquire_inherited_sample_rows(Relation onerel, int elevel,
--- 1478,1487 ----
  		/* CCI because we already updated the pg_class row in this command */
  		CommandCounterIncrement();
  		SetRelationHasSubclass(RelationGetRelid(onerel), false);
+ 		ereport(elevel,
+ 				(errmsg("skipping analyze of \"%s.%s\" inheritance tree --- this inheritance tree contains no child tables",
+ 						get_namespace_name(RelationGetNamespace(onerel)),
+ 						RelationGetRelationName(onerel))));
  		return 0;
  	}
  

--------------080504040801000502020508
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------080504040801000502020508--