Message-ID: <54461BEB.9000707@lab.ntt.co.jp>
Date: Tue, 21 Oct 2014 17:40:11 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.0;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Heikki Linnakangas <hlinnakangas@vmware.com>,
 Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
CC: noah@leadboat.com, shigeru.hanada@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: inherit support for foreign tables
References: <53F48245.6020204@lab.ntt.co.jp>
	<20140822025137.GA563733@tornado.leadboat.com>
	<53FEEF94.6040101@lab.ntt.co.jp>
 <20140902.142218.253402812.horiguchi.kyotaro@lab.ntt.co.jp>
 <5410A76B.20102@vmware.com> <541169C3.3030900@lab.ntt.co.jp>
 <54117D6E.3000008@vmware.com> <541187D5.4050301@lab.ntt.co.jp>
 <54118CDA.90009@vmware.com> <5412A112.9060009@lab.ntt.co.jp>
 <543D0261.6020803@lab.ntt.co.jp>
In-Reply-To: <543D0261.6020803@lab.ntt.co.jp>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

(2014/10/14 20:00), Etsuro Fujita wrote:
> Here are separated patches.
>
> fdw-chk.patch  - CHECK constraints on foreign tables
> fdw-inh.patch  - table inheritance with foreign tables
>
> The latter has been created on top of [1].

> [1] http://www.postgresql.org/message-id/540DA168.3040407@lab.ntt.co.jp

To be exact, it has been created on top of [1] and fdw-chk.patch.

I noticed that the latter disallows TRUNCATE on inheritance trees that 
contain at least one child foreign table.  But I think it would be 
better to allow it, with the semantics that we quietly ignore the child 
foreign tables and apply the operation to the child plain tables, which 
is the same semantics as ALTER COLUMN SET STORAGE on such inheritance 
trees.  Comments welcome.

Thanks,

Best regards,
Etsuro Fujita


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers