Subject: Re: automatically generating node support functions
To: Jacob Champion <pchampion@vmware.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <c1097590-a6a4-486a-64b1-e1f9cc0533ce@enterprisedb.com>
 <2f876203-7142-fa71-6d22-6ce00eb26869@enterprisedb.com>
 <c091e5cd-45f8-69ee-6a9b-de86912cc7e7@enterprisedb.com>
 <fcad8d71c44f6dd00fb50d052f1391a6a0bf1347.camel@vmware.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <5451a7c4-3ccc-8b28-80d0-549e030cc01d@enterprisedb.com>
Date: Tue, 7 Sep 2021 10:57:02 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <fcad8d71c44f6dd00fb50d052f1391a6a0bf1347.camel@vmware.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/5451a7c4-3ccc-8b28-80d0-549e030cc01d%40enterprisedb.com>
Precedence: bulk

On 02.09.21 20:53, Jacob Champion wrote:
>> 0004-Make-node-output-prefix-match-node-structure-name.patch
>>
>> Some nodes' output/read functions use a label that is slightly different
>> from their node name, e.g., "NOTIFY" instead of "NOTIFYSTMT".  This
>> cleans that up so that an automated approach doesn't have to deal with
>> these special cases.
> 
> Is there any concern about the added serialization length, or is that
> trivial in practice? The one that particularly caught my eye is
> RANGETBLENTRY, which was previously RTE. But I'm not very well-versed
> in all the places these strings can be generated and stored.

These are just matters of taste.  Let's wait a bit more to see if anyone 
is concerned.

>> 0005-Add-Cardinality-typedef.patch
>>
>> Adds a typedef Cardinality for double fields that store an estimated row
>> or other count.  Works alongside Cost and Selectivity.
> 
> Should RangeTblEntry.enrtuples also be a Cardinality?

Yes, I'll add that.