Message-ID: <545C8020.2070509@lab.ntt.co.jp>
Date: Fri, 07 Nov 2014 17:17:36 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.0;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: furuyao@pm.nttdata.co.jp, noah@leadboat.com
CC: shigeru.hanada@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp,
 pgsql-hackers@postgresql.org, teranishih@nttdata.co.jp
Subject: Re: inherit support for foreign tables
References: <53393E18.3080901@lab.ntt.co.jp> <533C01C7.6030809@lab.ntt.co.jp>
 <53706FB6.6000403@lab.ntt.co.jp>
 <20140620.170406.123403564.horiguchi.kyotaro@lab.ntt.co.jp>
 <20140702022327.GC1586927@tornado.leadboat.com>
 <53F48245.6020204@lab.ntt.co.jp>
 <20140822025137.GA563733@tornado.leadboat.com>
 <53FEEF94.6040101@lab.ntt.co.jp> <543F7639.300@lab.ntt.co.jp>
 <A9C510524E235E44AE909CD4027AE196BF7D6FB26C@MBX-MSG-SV03.msg.nttdata.co.jp>
In-Reply-To: 
 <A9C510524E235E44AE909CD4027AE196BF7D6FB26C@MBX-MSG-SV03.msg.nttdata.co.jp>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi Furuya-san,

(2014/11/07 16:54), furuyao@pm.nttdata.co.jp wrote:
>> (2014/08/28 18:00), Etsuro Fujita wrote:
>>> (2014/08/22 11:51), Noah Misch wrote:
>>>> Today's ANALYZE VERBOSE messaging for former inheritance parents
>>>> (tables with relhassubclass = true but no pg_inherits.inhparent
>>>> links) is deceptive, and I welcome a fix to omit the spurious
>>>> message.  As defects go, this is quite minor.  There's fundamentally
>>>> no value in collecting inheritance tree statistics for such a parent,
>>>> and no PostgreSQL command will do so.
>>
>>>> A
>>>> credible alternative is to emit a second message indicating that we
>>>> skipped the inheritance tree statistics after all, and why we skipped
>>>> them.
>>
>>> I'd like to address this by emitting the second message as shown below:
>>
>>> A separate patch (analyze.patch) handles the former case in a similar
>> way.
>>
>> I'll add to the upcoming CF, the analyze.patch as an independent item,
>> which emits a second message indicating that we skipped the inheritance
>> tree statistics and why we skipped them.
> 
> I did a review of the patch.
> There was no problem.
> I confirmed the following.
> 
> 1. applied cleanly and compilation was without warnings and errors
> 2. all regress tests was passed ok
> 3. The message output from ANALYZE VERBOSE.
> 
> Following are the SQL which I used to check messages.
> 
> create table parent (id serial);
> create table child (name text) inherits (parent);
> ANALYZE VERBOSE parent ;
> drop table child ;
> ANALYZE VERBOSE parent ;

I think that that is a correct test for this patch.

Thanks for the review!

Best regards,
Etsuro Fujita


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers