From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andres Freund <andres@anarazel.de>, Thomas Munro <thomas.munro@gmail.com>,
        Noah Misch <noah@leadboat.com>, Julien Rouhaud <rjuju123@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
In-reply-to: <YkVetIPIk1ScfC9Q@paquier.xyz>
References: <YeYj4DU5qY/rtKXT@paquier.xyz>
 <20220213045041.qhbw3ue6xmojts6c@alap3.anarazel.de>
 <Ygsl4Q7MARNY/OWI@paquier.xyz> <YgyEYkbf/M6Q9C+F@paquier.xyz>
 <Yh8VU5Ipd2m3jbPX@paquier.xyz>
 <20220302080729.q6wej3zlyaorjhri@alap3.anarazel.de>
 <YiBMKm6PYW2GN++2@paquier.xyz> <YkUpwzGHcAKlj81C@paquier.xyz>
 <502623.1648702814@sss.pgh.pa.us>
 <20220331053616.u446wsr732quuzer@alap3.anarazel.de>
 <YkVetIPIk1ScfC9Q@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 31 Mar 2022 16:56:36 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <547428.1648734590.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 31 Mar 2022 09:49:50 -0400
Message-ID: <547429.1648734590@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/547429.1648734590%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Mar 30, 2022 at 10:36:16PM -0700, Andres Freund wrote:
>> On 2022-03-31 01:00:14 -0400, Tom Lane wrote:
>>> How well does this patch work with pre-14 buildfarm clients?

>> Looks to me like it'll just run the test twice, once via TestUpgrade, o=
nce via
>> taptest. It's possible that there could be trouble somehow due to dupli=
cated
>> log files or something?

> Hmm.  TestUpgrade.pm also uses tmp_check/, and the TAP tests would
> remove this path before running.  Still, all the contents of the logs
> would be printed out before moving to the next tests at the end of
> check-pg_upgrade.  It does not seem like this double run is going to
> be an issue on this side. =


Well, let's go ahead with it and see what happens.  If it's too
much of a mess we can always revert.

			regards, tom lane