Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1zHE-005Whs-1P for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Sep 2026 04:42:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1x1zHA-00Fpfo-38 for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Sep 2026 04:42:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1zHA-00FpfS-20 for pgsql-hackers@lists.postgresql.org; Thu, 03 Sep 2026 04:42:12 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1x1zH7-00000003kTU-3mkE for pgsql-hackers@postgresql.org; Thu, 03 Sep 2026 04:42:11 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-49b0dbfbf7bso12321095e9.2 for ; Wed, 02 Sep 2026 21:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1788410528; x=1789015328; darn=postgresql.org; h=message-id:date:content-transfer-encoding:content-id:content-type :mime-version:comments:references:in-reply-to:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to:content-type; bh=vk8yv4nuncuzjWp+d9B/bBGghSTqZ87y+2WKpVQlBg0=; b=ZbuLHk/DIoKAVqmFe8U5jSEo+AmQRgjh8NFjK4uoEIG9ANi94XCqi2Tvd67jZo4MVD WG7N1yL7TLWrYplfmJi7KlRLC81D1wbq9M757nz1xYaWHFq454FIY/aGaCAt4rTZTfAX MeYZxagD4Mcv7Xmfap2ee/2+oj+/IQXFL70VKKNHm+AYFMG7mw6bmDatEvzneYKl9JeV ECHVpLR10alurIlvK1OHGX1fwHEvx6EMSJ/Fv41+3/zTk+9Te5jgJwnMPjbuX2SbsikE wA7j7Z9BabKbd8uBAHQKE85xyPVEm9HFkv3SEulvzNuvj46T4cu9S/z1ZmW5ylR+3x6n r8/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788410528; x=1789015328; h=message-id:date:content-transfer-encoding:content-id:content-type :mime-version:comments:references:in-reply-to:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=vk8yv4nuncuzjWp+d9B/bBGghSTqZ87y+2WKpVQlBg0=; b=idP8xSvnIJ2SOBfoLXuvPKkHXjZUMGaFT8b10vc9j4y2ub254F+r5Nm90hYzcxAF8s O6wf6+FocDL0d2UuMjpyPl4S9BfTOiiZTP/peCfwhB49WdIxkan/5wfln/VUWowTGslf 7dEjjbHDZdoyI7wRRD3YtCUAnJDX4HHAJAgfVYNxre6W6vhXvgSY4BID41gbago3473S pZp9rvIN8YeycPsnJZSoQgoVhfdYvyR2Eayx41zyRnUlA0CRFiYxtPtEsLwU1NDjruGi gcAJjQvo9yhrht+5gZOBLELyBCCa2mOyp/xfzwE8REpDDAyWV0VeuA+1vNPjqD6oWX33 dKsg== X-Forwarded-Encrypted: i=1; AKwUvBxLuBQxnsGasN2fKPKKRp8Lo9lE2Zm8Ot6dTKFPZEW5s2TMEO6Sy7zmpC2LCeOnJ97BTibAJ/01UjQflTKw@postgresql.org X-Gm-Message-State: AFuF++lhDgvsNP2wOmu89TcCaPsk2mBTACcfJ/zhnp6NGwnuckBFNZXW IQU1J4wbxqF1uXcnzfUSi46txlsdHrpfYkhLoaOeXUXjvDbow4IIvYp9C6Ca2EPF9z0= X-Gm-Gg: AYBFou0jHhfgAAFHQcU+V6vji9VtQ4O/Aee5CAyst8H99uAnX761atkHMKkorJYiFPv rTnFyRhl8FbOcHBcF4gJCD0PawcoZRMiEEkGOkqfPUjA5dxbo32ZmvLMTy+LKmTAVfXK1YoIlWt Q2koXsfhthmweZE1QkVkgY4b12CLu1UbTqAhZAGk2Ep2fS7w7OdYNNwuHTsVwdiTKHBk3bSsri9 aygWWtHWB4OUCCGaQsWpLH/CxtPInlfPvEZECR3T7MZ6GUT9oJbTxSfDfibi1f5OkTqscr4xv2q sB5tG6XIizgkKXLITB0mtgbBk+ysGpDPukJ6uYL/bI4MGHINv0eCRwL/L0wBpISQL8W/WK0lqhb rGbiUYm/XjEbg1NgcrH6lOEX1J1rzDi/2/rhdPv+BSG/nES82iOCHqKZ2For5zxqgSx3git4hzM R8xrN5fDJrUBH267XynlksczGYMQ9EiV80Lsh8RMQc6SH9s7rPNEsc5Hui3SIXAKpmUE9xAO2dA w== X-Received: by 2002:a05:600c:6209:b0:495:4d5c:903e with SMTP id 5b1f17b1804b1-49ce582039fmr174190775e9.7.1788410527618; Wed, 02 Sep 2026 21:42:07 -0700 (PDT) Received: from localhost (109-81-170-190.rct.o2.cz. [109.81.170.190]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce47b9817sm88955975e9.1.2026.09.02.21.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 21:42:07 -0700 (PDT) From: Antonin Houska To: Osama Abdul Qader cc: Alvaro Herrera , Fujii Masao , Nathan Bossart , pgsql-hackers@postgresql.org Subject: Re: REPACK (ANALYZE) within transaction block segfaults In-reply-to: References: <15397.1788338846@localhost> Comments: In-reply-to Osama Abdul Qader message dated "Wed, 02 Sep 2026 17:24:13 +0530." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5476.1788410526.1@localhost> Content-Transfer-Encoding: quoted-printable Date: Thu, 03 Sep 2026 06:42:06 +0200 Message-ID: <5477.1788410526@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Osama Abdul Qader wrote: > I have prepared a patch that rejects REPACK (ANALYZE) with PreventInTran= sactionBlock(), consistent with the existing restriction for > REPACK (CONCURRENTLY). I also added a regression test covering execution= inside a transaction block. > = > The patch applies cleanly to the current tree and passes git diff --chec= k. Is this a new version of [1]? If so, I'm not sure it addresses all the problems mentioned in [2]. And regarding regression tests, it misses the changes in expected/cluster.out. [1] https://www.postgresql.org/message-id/49398.1787944525%40localhost [2] https://www.postgresql.org/message-id/CAHGQGwEezdMUixhJ-N0YO0OFUmh0uPa= XRDkds5FS-5dmdwz4Bg%40mail.gmail.com -- = Antonin Houska Web: https://www.cybertec-postgresql.com