Message-ID: <5480CDAA.4020203@dunslane.net>
Date: Thu, 04 Dec 2014 16:10:02 -0500
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Peter Eisentraut <peter_e@gmx.net>, Bruce Momjian <bruce@momjian.us>
CC: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org,
 Josh Berkus <josh@agliodbs.com>, Robert Haas <robertmhaas@gmail.com>,
 Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
References: <51DB171F.2090108@dunslane.net>
 <201307122350.23726.cedric@2ndquadrant.com> <1739933.FyLmpy7Q73@obelix>
 <5248B32E.1090001@dunslane.net> <1381193255.25702.4.camel@vanquo.pezone.net>
 <525410EC.9010002@dunslane.net> <1381455307.5264.14.camel@vanquo.pezone.net>
 <525769CE.3010201@dunslane.net> <20140201021908.GA24521@momjian.us>
 <52EC5BB6.6060305@dunslane.net> <20140201022855.GB31141@momjian.us>
 <546D6A0E.9080608@gmx.net> <54808E1A.1070208@gmx.net>
 <5480B9BB.6060301@gmx.net> <5480C846.6090302@dunslane.net>
In-Reply-To: <5480C846.6090302@dunslane.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 12/04/2014 03:47 PM, Andrew Dunstan wrote:
>
> On 12/04/2014 02:44 PM, Peter Eisentraut wrote:
>> On 12/4/14 11:38 AM, Peter Eisentraut wrote:
>>> On 11/19/14 11:11 PM, Peter Eisentraut wrote:
>>>> I noticed this item was still in the 9.4 code.  Looking at the 
>>>> original
>>>> submission
>>>> (http://www.postgresql.org/message-id/201306181552.36673.cedric@2ndquadrant.com, 
>>>>
>>>> patch 0001), I think the original reason for adding this was wrong to
>>>> begin with.
>>> I have applied all three patches to 9.4 and 9.5.  So this issue is now
>>> resolved.
>> Apparently, some buildfarm module is unhappy with this:
>>
>> http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=sittella&dt=2014-12-04%2017%3A16%3A29&stg=RedisFDW-build 
>>
>>
>> Is there some custom code running there?  I don't know how that error
>> would happen otherwise?
>>
>>
>
>
> You have broken two buildfarm instances that build and test external 
> modules - in one case the Redis FDW module and in the other the File 
> Text Array FDW. I will see what can be retrieved.
>
>


I think this needs to be reverted. This has broken two modules that are 
not even using vpath builds.

You can see the relevant Makefiles at: 
<https://github.com/adunstan/file_text_array_fdw/blob/master/Makefile> 
and <https://github.com/pg-redis-fdw/redis_fdw/blob/master/Makefile>.

IIRC, the code you found convoluted and removed was required precisely 
to prevent this sort of error.

cheers

andrew


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers