From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Robert Haas <robertmhaas@gmail.com>, Fabien COELHO <coelho@cri.ensmp.fr>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        David Steele <david@pgmasters.net>,
 Andres Freund <andres@anarazel.de>,
        Noah Misch <noah@leadboat.com>, Stephen Frost <sfrost@snowman.net>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Suraj Kharage <suraj.kharage@enterprisedb.com>,
        tushar <tushar.ahuja@enterprisedb.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        Rushabh Lathia <rushabh.lathia@gmail.com>,
        Tels <nospam-pg-abuse@bloodgate.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        vignesh C <vignesh21@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: backup manifests and contemporaneous buildfarm failures
In-reply-to: <7330a7c7-ce5f-9769-39a1-bdb0b32bb4a6@2ndQuadrant.com>
References: 
 <CA+TgmoazJ5wh+H77kjVfMnDh6WLh=oJodrwJ21SACSq5fojwPg@mail.gmail.com>
 <20200403205412.GA8279@alvherre.pgsql>
 <CA+TgmoaRbm-L1C2YkDVPx1TGN9ufxWjnaweTwKE=TQC-YOD=rg@mail.gmail.com>
 <CA+TgmoZ4bAbjd_Am=UiMpBrgPEO=7YarqvaAMrQYKP1GkkOaRg@mail.gmail.com>
 <alpine.DEB.2.21.2004032346550.16227@pseudo> <22394.1585951968@sss.pgh.pa.us>
 <CA+Tgmoah0khUqHG5vn8k=LJFO0mmNLyM3HtUmh4RBkq7W2GFgQ@mail.gmail.com>
 <3419.1585965125@sss.pgh.pa.us>
 <CA+TgmoYR6GKr1kc4KTBwXbNChDaJX8qnx7k+KKgtNnSiFgCumA@mail.gmail.com>
 <CA+TgmoaUOS5X64nKgFxNV7JHN4sRkNAJYW2gHz-LMb0Ej4xHig@mail.gmail.com>
 <24829.1586234244@sss.pgh.pa.us>
 <CAA8=A7-FFbnpVGg5-T-tvNLhLN_XkD6yGpJ9VHKqsROiHnsFFw@mail.gmail.com>
 <7330a7c7-ce5f-9769-39a1-bdb0b32bb4a6@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Wed, 08 Apr 2020 13:45:39 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5481.1586368778.1@sss.pgh.pa.us>
Date: Wed, 08 Apr 2020 13:59:38 -0400
Message-ID: <5482.1586368778@sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> OK, tricky, but here's what I did to get this working on fairywren.
> First, on Msys2 there is a problem with name mangling. We've had to fix
> this before by telling it to ignore certain argument prefixes.
> Second, once that was fixed rmdir was failing on the tablespace. On
> Windows this is a junction, so unlink is the correct thing to do, I
> believe, just as it is on Unix where it's a symlink.

Hmm, no opinion about the name mangling business, but the other part
seems like it might break jacana and/or bowerbird, which are currently
happy with this test?  (AFAICS we only have four Windows animals
running the TAP tests, and the fourth (drongo) hasn't reported in
for awhile.)

I guess we could commit it and find out.  I'm all for the simpler
coding if it works.

			regards, tom lane