Message-ID: <54AC3B8B.2020902@kaltenbrunner.cc>
Date: Tue, 06 Jan 2015 20:46:19 +0100
From: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Bruce Momjian <bruce@momjian.us>
CC: David Fetter <david@fetter.org>,
 Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Updating copyright notices to 2015 for PGDG
References: 
 <CAB7nPqSx0TzRz_0+t1oZXTrFns5ztKi6X4Zyh06tq7vvO2Qkng@mail.gmail.com>
 <20150103214537.GF26414@fetter.org> <20150106151917.GB13684@momjian.us>
In-Reply-To: <20150106151917.GB13684@momjian.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 01/06/2015 04:19 PM, Bruce Momjian wrote:
> On Sat, Jan  3, 2015 at 01:45:37PM -0800, David Fetter wrote:
>> On Sat, Jan 03, 2015 at 09:54:16PM +0900, Michael Paquier wrote:
>>> Hi all,
>>>
>>> Shouldn't we update the copyright notices to 2015 for PGDG like in
>>> 7e04792? I mean those things mainly:
>>> Portions Copyright (c) 1996-2014, PostgreSQL Global Development Group
>>> Regards,
>>
>> I just ran this:
>>
>>     ./src/tools/copyright.pl 
>>     Using current year:  2015
>>     Manually update doc/src/sgml/legal.sgml and src/interfaces/libpq/libpq.rc.in too.
>>     Also update ./COPYRIGHT and doc/src/sgml/legal.sgml in all back branches.
>>
>> and did what it said on the current branch.
>>
>> Please find patch attached.
> 
> I will run the script today.  I didn't do it earlier because I want to
> be current on reading community email before doing it.

hmm is it intentional that the commit also changed other files?

looks like the commited patch added newlines to various files that had
none before for example:

src/test/isolation/specs/nowait-2.spec
src/test/isolation/specs/nowait-3.spec
src/test/isolation/specs/skip-locked-4.spec
src/test/modules/commit_ts/commit_ts.conf


http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=4baaf863eca5412e07a8441b3b7e7482b7a8b21a#patch1352


while I do think that the files should have newlines I dont think those
should be added in a copyright bump commit and I think the script might
actually break files where we specifically dont want a newline (afaik we
dont have atm but still)


Stefan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers