Message-ID: <54C8156E.1080500@BlueTreble.com>
Date: Tue, 27 Jan 2015 16:47:10 -0600
From: Jim Nasby <Jim.Nasby@BlueTreble.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Haribabu Kommi <kommi.haribabu@gmail.com>, Abhijit Menon-Sen
 <ams@2ndquadrant.com>
CC: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 "Prabakaran, Vaishnavi" <vaishnavip@fast.au.fujitsu.com>, Magnus Hagander
 <magnus@hagander.net>, Jaime Casanova <jaime@2ndquadrant.com>
Subject: Re: Providing catalog view to pg_hba.conf file - Patch
 submission
References: <F40B0968DB0A904DA78A924E633BE78645FE29@SYDEXCHTMP2.au.fjanz.com>
 <CABUevEwzKy5JR8papHw5Amk=Ok6uddYtwQ+gJntmLdrx2wOgbA@mail.gmail.com>
 <82897A1301080E4B8E461DDAA0FFCF14DDE1@SYD1216>
 <82897A1301080E4B8E461DDAA0FFCF14FD6E@SYD1216>
 <20140629165554.GA5984@toroid.org> <20140630070646.GY31357@toroid.org>
 <CAJrrPGe3sZWKFfsHDCJMXfBOqkf6_w6R_DpsUYn2vQK_tVeU1g@mail.gmail.com>
In-Reply-To: 
 <CAJrrPGe3sZWKFfsHDCJMXfBOqkf6_w6R_DpsUYn2vQK_tVeU1g@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2015 22:47:28.2016 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR11MB0340
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 1/27/15 1:04 AM, Haribabu Kommi wrote:
> On Mon, Jun 30, 2014 at 5:06 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
>> I think having two columns would work. The columns could be called
>> "database" and "database_list" and "user" and "user_list" respectively.
>>
>> The database column may contain one of "all", "sameuser", "samegroup",
>> "replication", but if it's empty, database_list will contain an array of
>> database names. Then ("all", {}) and ("", {all}) are easily separated.
>> Likewise for user and user_list.
>
> Thanks for the review.
>
> I corrected all the review comments except the one to add two columns
> as (database, database_list and user, user_list). I feel this may cause
> some confusion to the users.
>
> Here I attached the latest version of the patch.
> I will add this patch to the next commitfest.

Apologies if this was covered, but why isn't the IP address an inet instead of text?

Also, what happens if someone reloads the config in the middle of running the SRF? ISTM it'd be better to do something like process all of parsed_hba_lines into a tuplestore. Obviously there's still a race condition there, but at least it's a lot smaller, and AFAIK no worse than the pg_stats views.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers