Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YGWGo-0008AS-OX for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jan 2015 17:19:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YGWGo-0001wj-7u for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jan 2015 17:19:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YGWGl-0001u0-UA for pgsql-hackers@postgresql.org; Wed, 28 Jan 2015 17:19:11 +0000 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]) by magus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1YGWGi-0006uh-Fe for pgsql-hackers@postgresql.org; Wed, 28 Jan 2015 17:19:10 +0000 Received: from sc9-mailhost3.vmware.com (sc9-mailhost3.vmware.com [10.113.161.73]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 81EAF298CE; Wed, 28 Jan 2015 09:19:05 -0800 (PST) Received: from EX13-CAS-005.vmware.com (EX13-CAS-005.vmware.com [10.113.191.55]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 7D206404BF; Wed, 28 Jan 2015 09:19:05 -0800 (PST) Received: from [192.168.1.90] (10.113.160.246) by EX13-MBX-024.vmware.com (10.113.191.44) with Microsoft SMTP Server (TLS) id 15.0.913.22; Wed, 28 Jan 2015 09:19:04 -0800 Message-ID: <54C919FD.1000809@vmware.com> Date: Wed, 28 Jan 2015 19:18:53 +0200 From: Heikki Linnakangas Organization: VMware User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Stephen Frost , Robert Haas CC: Magnus Hagander , Tom Lane , PostgreSQL-development Subject: Re: PQgetssl() and alternative SSL implementations References: <53F1E989.8020609@vmware.com> <10419.1408475397@sss.pgh.pa.us> <53F3C87E.2080401@vmware.com> <54C8FCB0.4050304@vmware.com> <20150128165847.GY3854@tamriel.snowman.net> In-Reply-To: <20150128165847.GY3854@tamriel.snowman.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.113.160.246] X-ClientProxiedBy: EX13-CAS-013.vmware.com (10.113.191.65) To EX13-MBX-024.vmware.com (10.113.191.44) X-Pg-Spam-Score: -6.9 (------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 01/28/2015 06:58 PM, Stephen Frost wrote: >> >Although I think "OpenSSL SSL" is a little bit duplicatively >> >redundant. Why not just "OpenSSL"? > I wondered also, but figured it was probably because it's OpenSSL's > "ssl" structure, which then made sense. Right, that was the idea. I wanted it to include the word "OpenSSL", to make it clear in the callers that it's specific to OpenSSL. And SSL, because that's the name of the struct. I agree it looks silly, though. One idea is to have two separate arguments: the implementation name, and the struct name. PQgetSSLstruct(&ssl, "OpenSSL", "SSL") would look less silly. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers