Message-ID: <54D10C44.7040607@vmware.com>
Date: Tue, 3 Feb 2015 19:58:28 +0200
From: Heikki Linnakangas <hlinnakangas@vmware.com>
Organization: VMware
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.3.0
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>,
 Magnus Hagander <magnus@hagander.net>, PostgreSQL-development
 <pgsql-hackers@postgresql.org>
Subject: Re: PQgetssl() and alternative SSL implementations
References: <53F1E989.8020609@vmware.com>
 <CA+TgmoZDJ6CKiuBMqNk3iS7LQ9GZuzS7RTYSOvRu8kJjRKWLng@mail.gmail.com>
 <CABUevExpTZpMAMvr=BkeO5-XG_zgZP=TKdyCCpgEpYc0Htjr8Q@mail.gmail.com>
 <10419.1408475397@sss.pgh.pa.us>
 <CABUevEy03OvP3N3wBRVP7BcmwcHf=Qi6Crb2MHo4dVmG--ZnVg@mail.gmail.com>
 <CA+TgmoaKHd+HW8kOgzovdSTWhauEsV0qeRsxPLpEZfSNDiSP=g@mail.gmail.com>
 <53F3C87E.2080401@vmware.com> <54C8FCB0.4050304@vmware.com>
 <CA+TgmoYrAH=o8m9959O_TgHm7OcK9C=f3WJfUHryb4pzu5uZ0A@mail.gmail.com>
 <20150128165847.GY3854@tamriel.snowman.net> <54C919FD.1000809@vmware.com>
 <3934.1422468320@sss.pgh.pa.us>
In-Reply-To: <3934.1422468320@sss.pgh.pa.us>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 01/28/2015 08:05 PM, Tom Lane wrote:
> Heikki Linnakangas <hlinnakangas@vmware.com> writes:
>> Right, that was the idea. I wanted it to include the word "OpenSSL", to
>> make it clear in the callers that it's specific to OpenSSL. And SSL,
>> because that's the name of the struct. I agree it looks silly, though.
>> One idea is to have two separate arguments: the implementation name, and
>> the struct name. PQgetSSLstruct(&ssl, "OpenSSL", "SSL") would look less
>> silly.
>
> That's probably overkill.  Why not establish a convention that the "main"
> API struct for the library doesn't have to be named?  So it's just
> PQgetSSLstruct(&ssl, "OpenSSL"), and you only need strange naming if
> you're dealing with a library that actually has more than one API object
> that needs to be fetched this way.  (That set is likely empty...)

Works for me. Committed that way.

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers