Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YUbAi-0001vK-Gk for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Mar 2015 13:23:08 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YUbAi-0005Ut-0n for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Mar 2015 13:23:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YUbAh-0005Un-2n for pgsql-hackers@postgresql.org; Sun, 08 Mar 2015 13:23:07 +0000 Received: from mout.gmx.net ([212.227.17.20]) by magus.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YUbAZ-0005ta-4H for pgsql-hackers@postgresql.org; Sun, 08 Mar 2015 13:23:06 +0000 Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MUm1o-1XwTFM1hO8-00Y6HN for ; Sun, 08 Mar 2015 14:22:56 +0100 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 99D5A20862 for ; Sun, 8 Mar 2015 09:22:53 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Sun, 08 Mar 2015 09:22:55 -0400 X-Sasl-enc: eHIPWe/jY/p9efJkPAnxdpjbUNnp5mKRemw7cbBICxD1 1425820974 Received: from [10.0.0.13] (unknown [67.165.24.246]) by mail.messagingengine.com (Postfix) with ESMTPA id A445F6800EB; Sun, 8 Mar 2015 09:22:54 -0400 (EDT) Message-ID: <54FC4D2D.8060901@gmx.net> Date: Sun, 08 Mar 2015 09:22:53 -0400 From: Peter Eisentraut User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Paquier CC: pgsql-hackers , Fabien COELHO Subject: Re: improving speed of make check-world References: <53ED9E6C.1080700@gmx.net> <54DFFE0C.4060100@gmx.net> In-Reply-To: Content-Type: multipart/mixed; boundary="------------090804070008030308020601" X-Provags-ID: V03:K0:8XTpwlsJ50zKh3Fii89hzgLgQ7zn3AnuzcEc0no/Pqe0vetu/LK Gpc1x/+lLwouF2jwOXTqqb8bW2QrNMilz1LM+jJBh+FMH0WHV+Z5Vzp+Df/lHmqG0FVeueE sp9jKGDGd5jGQOkYBAHZr6lHEbg2PEzcNKCfDlLQIS4TyGk4uTtgl0rD2C8uVjcShWxV+pr ie2N9ql8UgD+BuQrE/CdQ== X-UI-Out-Filterresults: notjunk:1; X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is a multi-part message in MIME format. --------------090804070008030308020601 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 2/24/15 3:06 AM, Michael Paquier wrote: > On Sun, Feb 15, 2015 at 11:01 AM, Peter Eisentraut wrote: >> Here is an updated patch. > > Nice patch. This is going to save a lot of resources. > > An update of vcregress.pl is necessary. This visibly just consists in > updating the options that have been renamed in pg_regress (don't mind > testing any code sent out). Well, that turns out to be more complicated than initially thought. Apparently, the msvc has a bit of a different idea of what check and installcheck do with respect to temporary installs. For instance, vcregress installcheck does not use psql from the installation but from the build tree. vcregress check uses psql from the build tree but other binaries (initdb, pg_ctl) from the temporary installation. It is hard for me to straighten this out by just looking at the code. Attached is a patch that shows the idea, but I can't easily take it further than that. > - {"top-builddir", required_argument, NULL, 11}, > + {"datadir", required_argument, NULL, 12}, > In pg_regress.c datadir is a new option but it is used nowhere, so it > could be as well removed. Yeah, that's an oversight that is easily corrected. --------------090804070008030308020601 Content-Type: application/x-patch; name="regress-temp-instance-msvc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="regress-temp-instance-msvc.patch" ZGlmZiAtLWdpdCBhL3NyYy90b29scy9tc3ZjL3ZjcmVncmVzcy5wbCBiL3Ny Yy90b29scy9tc3ZjL3ZjcmVncmVzcy5wbAppbmRleCBiZDNkZDJjLi4xZTA5 Yzc0IDEwMDY0NAotLS0gYS9zcmMvdG9vbHMvbXN2Yy92Y3JlZ3Jlc3MucGwK KysrIGIvc3JjL3Rvb2xzL21zdmMvdmNyZWdyZXNzLnBsCkBAIC05NCw3ICs5 NCw3IEBAIHN1YiBpbnN0YWxsY2hlY2sKIAlteSBAYXJncyA9ICgKIAkJIi4u Ly4uLy4uLyRDb25maWcvcGdfcmVncmVzcy9wZ19yZWdyZXNzIiwKIAkJIi0t ZGxwYXRoPS4iLAotCQkiLS1wc3FsZGlyPS4uLy4uLy4uLyRDb25maWcvcHNx bCIsCisJCSItLWJpbmRpcj0uLi8uLi8uLi8kQ29uZmlnL3BzcWwiLAogCQki LS1zY2hlZHVsZT0ke3NjaGVkdWxlfV9zY2hlZHVsZSIsCiAJCSItLWVuY29k aW5nPVNRTF9BU0NJSSIsCiAJCSItLW5vLWxvY2FsZSIpOwpAQCAtMTA2LDM5 ICsxMDYsNTYgQEAgc3ViIGluc3RhbGxjaGVjawogCiBzdWIgY2hlY2sKIHsK KwlteSAkY3dkID0gZ2V0Y3dkKCk7CisKKwlzeXN0ZW0oJDAsICdpbnN0YWxs LnBsJywgIiRjd2QvdG1wX2luc3RhbGwiKTsKKwlteSAkc3RhdHVzID0gJD8g Pj4gODsKKwlleGl0ICRzdGF0dXMgaWYgJHN0YXR1czsKKworCSRFTlZ7UEFU SH0gPSAiJGN3ZC90bXBfaW5zdGFsbC9iaW47JGN3ZC90bXBfaW5zdGFsbC9s aWI7JEVOVntQQVRIfSI7CisKIAlteSBAYXJncyA9ICgKIAkJIi4uLy4uLy4u LyRDb25maWcvcGdfcmVncmVzcy9wZ19yZWdyZXNzIiwKIAkJIi0tZGxwYXRo PS4iLAotCQkiLS1wc3FsZGlyPS4uLy4uLy4uLyRDb25maWcvcHNxbCIsCisJ CSItLWJpbmRpcj0iLAogCQkiLS1zY2hlZHVsZT0ke3NjaGVkdWxlfV9zY2hl ZHVsZSIsCiAJCSItLWVuY29kaW5nPVNRTF9BU0NJSSIsCiAJCSItLW5vLWxv Y2FsZSIsCi0JCSItLXRlbXAtaW5zdGFsbD0uL3RtcF9jaGVjayIsCi0JCSIt LXRvcC1idWlsZGRpcj1cIiR0b3BkaXJcIiIpOworCQkiLS10ZW1wLWluc3Rh bmNlPS4vdG1wX2NoZWNrIik7CiAJcHVzaChAYXJncywgJG1heGNvbm4pICAg ICBpZiAkbWF4Y29ubjsKIAlwdXNoKEBhcmdzLCAkdGVtcF9jb25maWcpIGlm ICR0ZW1wX2NvbmZpZzsKIAlzeXN0ZW0oQGFyZ3MpOwotCW15ICRzdGF0dXMg PSAkPyA+PiA4OworCSRzdGF0dXMgPSAkPyA+PiA4OwogCWV4aXQgJHN0YXR1 cyBpZiAkc3RhdHVzOwogfQogCiBzdWIgZWNwZ2NoZWNrCiB7CiAJY2hkaXIg JHN0YXJ0ZGlyOworCiAJc3lzdGVtKCJtc2J1aWxkIGVjcGdfcmVncmVzc2lv bi5wcm9qIC9wOmNvbmZpZz0kQ29uZmlnIik7CiAJbXkgJHN0YXR1cyA9ICQ/ ID4+IDg7CiAJZXhpdCAkc3RhdHVzIGlmICRzdGF0dXM7CisKKwlteSAkY3dk ID0gZ2V0Y3dkKCk7CisKKwlzeXN0ZW0oJDAsICdpbnN0YWxsLnBsJywgIiRj d2QvdG1wX2luc3RhbGwiKTsKKwkkc3RhdHVzID0gJD8gPj4gODsKKwlleGl0 ICRzdGF0dXMgaWYgJHN0YXR1czsKKworCSRFTlZ7UEFUSH0gPSAiJGN3ZC90 bXBfaW5zdGFsbC9iaW47JGN3ZC90bXBfaW5zdGFsbC9saWI7JEVOVntQQVRI fSI7CisKIAljaGRpciAiJHRvcGRpci9zcmMvaW50ZXJmYWNlcy9lY3BnL3Rl c3QiOwogCSRzY2hlZHVsZSA9ICJlY3BnIjsKIAlteSBAYXJncyA9ICgKIAkJ Ii4uLy4uLy4uLy4uLyRDb25maWcvcGdfcmVncmVzc19lY3BnL3BnX3JlZ3Jl c3NfZWNwZyIsCi0JCSItLXBzcWxkaXI9Li4vLi4vLi4vJENvbmZpZy9wc3Fs IiwKKwkJIi0tYmluZGlyPSIsCiAJCSItLWRibmFtZT1yZWdyZXNzMSxjb25u ZWN0ZGIiLAogCQkiLS1jcmVhdGUtcm9sZT1jb25uZWN0dXNlcixjb25uZWN0 ZGIiLAogCQkiLS1zY2hlZHVsZT0ke3NjaGVkdWxlfV9zY2hlZHVsZSIsCiAJ CSItLWVuY29kaW5nPVNRTF9BU0NJSSIsCiAJCSItLW5vLWxvY2FsZSIsCi0J CSItLXRlbXAtaW5zdGFsbD0uL3RtcF9jaGsiLAorCQkiLS10ZW1wLWluc3Rh bmNlPS4vdG1wX2NoayIsCiAJCSItLXRvcC1idWlsZGRpcj1cIiR0b3BkaXJc IiIpOwogCXB1c2goQGFyZ3MsICRtYXhjb25uKSBpZiAkbWF4Y29ubjsKIAlz eXN0ZW0oQGFyZ3MpOwpAQCAtMTUzLDcgKzE3MCw3IEBAIHN1YiBpc29sYXRp b25jaGVjawogCQkiLi4vLi4vLi4vJENvbmZpZy9wZ19pc29sYXRpb25fcmVn cmVzcyIpOwogCW15IEBhcmdzID0gKAogCQkiLi4vLi4vLi4vJENvbmZpZy9w Z19pc29sYXRpb25fcmVncmVzcy9wZ19pc29sYXRpb25fcmVncmVzcyIsCi0J CSItLXBzcWxkaXI9Li4vLi4vLi4vJENvbmZpZy9wc3FsIiwKKwkJIi0tYmlu ZGlyPS4uLy4uLy4uLyRDb25maWcvcHNxbCIsCiAJCSItLWlucHV0ZGlyPS4i LAogCQkiLS1zY2hlZHVsZT0uL2lzb2xhdGlvbl9zY2hlZHVsZSIpOwogCXB1 c2goQGFyZ3MsICRtYXhjb25uKSBpZiAkbWF4Y29ubjsKQEAgLTIwMiw3ICsy MTksNyBAQCBzdWIgcGxjaGVjawogCQlwcmludCAiQ2hlY2tpbmcgJGxhbmdc biI7CiAJCW15IEBhcmdzID0gKAogCQkJIi4uLy4uLy4uLyRDb25maWcvcGdf cmVncmVzcy9wZ19yZWdyZXNzIiwKLQkJCSItLXBzcWxkaXI9Li4vLi4vLi4v JENvbmZpZy9wc3FsIiwKKwkJCSItLWJpbmRpcj0uLi8uLi8uLi8kQ29uZmln L3BzcWwiLAogCQkJIi0tZGJuYW1lPXBsX3JlZ3Jlc3Npb24iLCBAbGFuZ19h cmdzLCBAdGVzdHMpOwogCQlzeXN0ZW0oQGFyZ3MpOwogCQlteSAkc3RhdHVz ID0gJD8gPj4gODsKQEAgLTIzNyw3ICsyNTQsNyBAQCBzdWIgY29udHJpYmNo ZWNrCiAJCW15IEBvcHRzICA9IGZldGNoUmVncmVzc09wdHMoKTsKIAkJbXkg QGFyZ3MgID0gKAogCQkJIi4uLy4uLyRDb25maWcvcGdfcmVncmVzcy9wZ19y ZWdyZXNzIiwKLQkJCSItLXBzcWxkaXI9Li4vLi4vJENvbmZpZy9wc3FsIiwK KwkJCSItLWJpbmRpcj0uLi8uLi8kQ29uZmlnL3BzcWwiLAogCQkJIi0tZGJu YW1lPWNvbnRyaWJfcmVncmVzc2lvbiIsIEBvcHRzLCBAdGVzdHMpOwogCQlz eXN0ZW0oQGFyZ3MpOwogCQlteSAkc3RhdHVzID0gJD8gPj4gODsK --------------090804070008030308020601 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------090804070008030308020601--