Message-ID: <54FDC99C.5040100@commandprompt.com>
Date: Mon, 09 Mar 2015 09:26:04 -0700
From: "Joshua D. Drake" <jd@commandprompt.com>
Organization: Command Prompt, Inc.
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
CC: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Rethinking the parameter access hooks for plpgsql's
 benefit
References: <4146.1425872254@sss.pgh.pa.us>
 <CA+TgmoYGAV_RP-sL1MQqA8jYiYefN5YM16wDQS1pLKza0RHG+w@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoYGAV_RP-sL1MQqA8jYiYefN5YM16wDQS1pLKza0RHG+w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 03/09/2015 09:11 AM, Robert Haas wrote:
>
> On Sun, Mar 8, 2015 at 11:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Objections?  Even better ideas?
>
> I object on the grounds that we're three weeks past the deadline for
> the last CommitFest, and that we should be trying to get committed
> those patches that were submitted on time, not writing new ones that
> will further increase the amount of reviewing that needs to be done
> before we can get to beta, and perhaps the bug count of that
> eventually when it arrives.  In particular, I think that the fact that
> you haven't made more of an effort to give the GROUPING SETS patch a
> more detailed review is quite unfair to Andrew Gierth.  But regardless
> of that, this is untimely and should be pushed to 9.6.

 From the reading the original post it seems like the patch was 
developed on Sales Force's time, not TGLs. I do not think we get to have 
an opinion on that.

Thank you Tom for the efforts you made here, making the largest used PL 
better, faster, stronger is exactly the type of micro-changes we need to 
be looking at for further polish within the database.

JD

-- 
Command Prompt, Inc. - http://www.commandprompt.com/  503-667-4564
PostgreSQL Support, Training, Professional Services and Development
High Availability, Oracle Conversion, @cmdpromptinc

Now I get it: your service is designed for a customer
base that grew up with Facebook, watches Japanese seizure
robot anime, and has the attention span of a gnat.
I'm not that user., "Tyler Riddle"


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers