Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG1Ai-0000pB-TT for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Jan 2023 17:15:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pG1Ah-0004Iw-PD for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Jan 2023 17:15:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG1Ah-0004Im-Fn for pgsql-hackers@lists.postgresql.org; Thu, 12 Jan 2023 17:15:23 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG1Ad-0006WA-TV for pgsql-hackers@postgresql.org; Thu, 12 Jan 2023 17:15:23 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 4F9912B06842; Thu, 12 Jan 2023 12:15:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 12 Jan 2023 12:15:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673543716; x= 1673550916; bh=zrNiF3ziLcwaZl7phpIPvcck9FU0E1ns/vYSQymphyw=; b=i bXNdivB76yNT0KKxZdGVSro5vasM87OveVZZFLcNGKgPUTgGGPHZu7Q0O6uqoJnK e9D2ts81pKUN79S4PE5tyAQ/rhfN6aQY7NqS/NS4avxIgwtYpBGS18IbXUdoaBd3 qLvW/PFKwsgbetRkhm/2zWc8Cbb+MDAveRtnCc4GKe/PKYBpJMsIGbuDbsJ0Ig3R GmhklYhZtjkirFx29BDCggbL5MwwgWnYS7fNYjOlYA8eyvD0Xi9nYSxjZMRRmMC8 kB39KEaaQyaAiw1CpuecMhkj8FoDue8MdrhRn/aRMhrcbAccGm6IKgAz1MJ7unpz DX9P0RBjul5zzfNKWmWpQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepheelffeggedujeetiefh leetuddvieffhfffvdejvdffgeejkeduleduheduieefnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 12:15:15 -0500 (EST) Message-ID: <54b13402-b8ab-406a-d9a6-3542124ad6cf@enterprisedb.com> Date: Thu, 12 Jan 2023 18:15:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Refactor recordExtObjInitPriv() Content-Language: en-US To: Nathan Bossart Cc: pgsql-hackers References: <504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com> <20230112000437.GA2032194@nathanxps13> From: Peter Eisentraut In-Reply-To: <20230112000437.GA2032194@nathanxps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12.01.23 01:04, Nathan Bossart wrote: >> - classoid == AggregateRelationId || > I noticed that AggregateRelationId isn't listed in the ObjectProperty > array, so I think recordExtObjInitPriv() will begin erroring for that > classoid instead of ignoring it like we do today. Hmm, we do have some extensions in contrib that add aggregates (citext, intagg). I suspect that the aggregate function is actually registered into the extension via its pg_proc entry, so this wouldn't actually matter. But maybe the commenting should be clearer?