public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 6/6] 0003 review
3+ messages / 3 participants
[nested] [flat]
* [PATCH 6/6] 0003 review
@ 2021-02-15 15:36 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:36 UTC (permalink / raw)
---
src/test/regress/input/copy.source | 4 ++--
src/test/regress/output/copy.source | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/regress/input/copy.source b/src/test/regress/input/copy.source
index ddde33e7cc..4ee1b26326 100644
--- a/src/test/regress/input/copy.source
+++ b/src/test/regress/input/copy.source
@@ -204,7 +204,7 @@ drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
@@ -221,7 +221,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
diff --git a/src/test/regress/output/copy.source b/src/test/regress/output/copy.source
index 60f4206aa1..8ebfb7ae81 100644
--- a/src/test/regress/output/copy.source
+++ b/src/test/regress/output/copy.source
@@ -167,7 +167,7 @@ select * from parted_copytest where b = 2;
drop table parted_copytest;
--
-- progress reporting
---
+--
-- setup
-- reuse employer datatype, that has a small sized data set
create table progress_reporting (
@@ -181,7 +181,7 @@ create function notice_after_progress_reporting() returns trigger AS
$$
declare report record;
begin
- -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
+ -- We cannot expect 'pid' nor 'relid' to be consistent over runs due to
-- variance in system process ids, and concurrency in runs of tests.
-- Additionally, due to the usage of this test in pg_regress, the 'datid'
-- also is not consistent between runs.
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5--
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Proposal: Support custom authentication methods using hooks
@ 2022-02-25 17:33 Jeff Davis <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Davis @ 2022-02-25 17:33 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: samay sharma <[email protected]>; [email protected]
On Thu, 2022-02-24 at 20:47 -0500, Tom Lane wrote:
> ... and, since we can't readily enforce that the client only sends
> those cleartext passwords over suitably-encrypted connections, this
> could easily be a net negative for security. Not sure that I think
> it's a good idea.
I don't understand your point. Can't you just use "hostssl" rather than
"host"?
Also there are some useful cases that don't really require SSL, like
when the client and host are on the same machine, or if you have a
network secured some other way.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Proposal: Support custom authentication methods using hooks
@ 2022-02-25 17:40 Andres Freund <[email protected]>
parent: Jeff Davis <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Andres Freund @ 2022-02-25 17:40 UTC (permalink / raw)
To: Jeff Davis <[email protected]>; +Cc: Tom Lane <[email protected]>; samay sharma <[email protected]>; [email protected]
Hi,
On 2022-02-25 09:33:45 -0800, Jeff Davis wrote:
> On Thu, 2022-02-24 at 20:47 -0500, Tom Lane wrote:
> > ... and, since we can't readily enforce that the client only sends
> > those cleartext passwords over suitably-encrypted connections, this
> > could easily be a net negative for security. Not sure that I think
> > it's a good idea.
>
> I don't understand your point. Can't you just use "hostssl" rather than
> "host"?
And the extension could check Port->ssl_in_use before sendAuthRequest(AUTH_REQ_PASSWORD)
if it wanted to restrict it.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-02-25 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:36 [PATCH 6/6] 0003 review Tomas Vondra <[email protected]>
2022-02-25 17:33 Re: Proposal: Support custom authentication methods using hooks Jeff Davis <[email protected]>
2022-02-25 17:40 ` Re: Proposal: Support custom authentication methods using hooks Andres Freund <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox