Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M269872=pgsql-hackers-arkari@postgresql.org>)
 id 1YYJ78-0000pq-PF
 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Mar 2015 18:54:46 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M269872=pgsql-hackers-arkari@postgresql.org>)
 id 1YYJ78-0003fa-4E
 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Mar 2015 18:54:46 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <andreas@proxel.se>) id 1YYJ76-0003fT-Lz
 for pgsql-hackers@postgresql.org; Wed, 18 Mar 2015 18:54:44 +0000
Received: from smtp2.scorpionshops.com ([82.118.24.225]
 helo=kilimanjaro.scorpionshops.com)
 by magus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <andreas@proxel.se>) id 1YYJ73-0007vM-MP
 for pgsql-hackers@postgresql.org; Wed, 18 Mar 2015 18:54:43 +0000
Received: from [192.168.1.173] (92-32-205-89.tn.glocalnet.net [92.32.205.89])
 by kilimanjaro.scorpionshops.com (Postfix) with ESMTPSA id
 680AE7BC0F7; Wed, 18 Mar 2015 19:54:40 +0100 (CET)
Message-ID: <5509C9F2.9040403@proxel.se>
Date: Wed, 18 Mar 2015 19:54:42 +0100
From: Andreas Karlsson <andreas@proxel.se>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.5.0
MIME-Version: 1.0
To: Julien Tachoires <julmon@gmail.com>, Alex Shulgin <ash@commandprompt.com>
CC: Alvaro Herrera <alvherre@2ndquadrant.com>,
 Jaime Casanova <jaime@2ndquadrant.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
References: <4E8F1666.2060409@gmail.com>
	<CAFEQCbH756DyyAPQ1ykh3+b+kE1-EhWRww1WO_x5v38C-uLnUg@mail.gmail.com>
	<CAJKUy5itRAtv7A3y7nVKmKe8SZdTU5Q-OsPr4d3ySYqoHkzK1g@mail.gmail.com>
	<CAFEQCbGmVoeSVyeh8ZCJKpN+NKH2rgvZq1rMrKjZ+YE7RpM8zw@mail.gmail.com>
	<CAJKUy5gYJPR0ETVQQvSf2-mDfdsJU-7XSUVDFN_o4+ZaZtyATg@mail.gmail.com>
	<CAFEQCbGEjp6j6-XD4C-vDaAyRHh6aMbH__BWB3kBuT505LXQyw@mail.gmail.com>
	<CA+TgmoaJOK6yKMZw8sc5HzRD8hb0bzCV0U4JuNc3XdACmfQCYw@mail.gmail.com>
	<CAFEQCbESRGXLE4+tRAnazr8QmBJzfYPwc6GP1Daq0quyuyEpZQ@mail.gmail.com>
	<1323956011-sup-9589@alvh.no-ip.org>
	<CAFEQCbEq07OopgE5xFYv2Q3eMq45hRSJkjCBO+kvpJq9NEVhow@mail.gmail.com>
 <87r3wn5lhq.fsf@commandprompt.com> <54A2127D.5020907@proxel.se>
 <54F5CFDE.20301@gmail.com> <54FE2D6B.8000205@proxel.se>
 <5502C06E.5010300@gmail.com> <55044F48.1090701@proxel.se>
 <550468FF.9080707@gmail.com> <5504FBA9.3020900@proxel.se>
 <5504FDBE.4000006@proxel.se> <5505DD23.2020207@gmail.com>
 <5507DF26.3090206@gmail.com>
In-Reply-To: <5507DF26.3090206@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 03/17/2015 09:00 AM, Julien Tachoires wrote:
> Here is a new version fixing this issue. I've added a new kind of TOC
> entry for being able to handle pg_restore --no-tablespace case.

Looks good but I think one minor improvement could be to set the table 
space of the toast entires to the same as the tablespace of the table to 
reduce the amount of "SET default_tablespace". What do you think?

-- 
Andreas Karlsson


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers