agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Julien Tachoires <julmon@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
To: Alex Shulgin <ash@commandprompt.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jaime Casanova <jaime@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
Date: Sat, 21 Mar 2015 13:19:37 +0100
Message-ID: <550D61D9.9060602@gmail.com> (raw)
In-Reply-To: <550B5CBE.3020601@proxel.se>
References: <4E8F1666.2060409@gmail.com>
<CAJKUy5itRAtv7A3y7nVKmKe8SZdTU5Q-OsPr4d3ySYqoHkzK1g@mail.gmail.com>
<CAFEQCbGmVoeSVyeh8ZCJKpN+NKH2rgvZq1rMrKjZ+YE7RpM8zw@mail.gmail.com>
<CAJKUy5gYJPR0ETVQQvSf2-mDfdsJU-7XSUVDFN_o4+ZaZtyATg@mail.gmail.com>
<CAFEQCbGEjp6j6-XD4C-vDaAyRHh6aMbH__BWB3kBuT505LXQyw@mail.gmail.com>
<CA+TgmoaJOK6yKMZw8sc5HzRD8hb0bzCV0U4JuNc3XdACmfQCYw@mail.gmail.com>
<CAFEQCbESRGXLE4+tRAnazr8QmBJzfYPwc6GP1Daq0quyuyEpZQ@mail.gmail.com>
<1323956011-sup-9589@alvh.no-ip.org>
<CAFEQCbEq07OopgE5xFYv2Q3eMq45hRSJkjCBO+kvpJq9NEVhow@mail.gmail.com>
<87r3wn5lhq.fsf@commandprompt.com>
<54A2127D.5020907@proxel.se>
<54F5CFDE.20301@gmail.com>
<54FE2D6B.8000205@proxel.se>
<5502C06E.5010300@gmail.com>
<55044F48.1090701@proxel.se>
<550468FF.9080707@gmail.com>
<5504FBA9.3020900@proxel.se>
<5504FDBE.4000006@proxel.se>
<5505DD23.2020207@gmail.com>
<5507DF26.3090206@gmail.com>
<5509C9F2.9040403@proxel.se>
<550AF15E.4020006@gmail.com>
<550B5CBE.3020601@proxel.se>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 20/03/2015 00:33, Andreas Karlsson wrote:
> On 03/19/2015 04:55 PM, Julien Tachoires wrote:
>> On 18/03/2015 19:54, Andreas Karlsson wrote:
>>> Looks good but I think one minor improvement could be to set the table
>>> space of the toast entires to the same as the tablespace of the table to
>>> reduce the amount of "SET default_tablespace". What do you think?
>>
>> Yes, you're right, some useless "SET default_tablespace" were added for
>> each ALTER TABLE SET TOAST TABLESPACE statement. It's now fixed with
>> this new patch. Thanks.
>
> I am confused by your fix. Wouldn't cleaner fix be to use
> tbinfo->reltablespace rather than tbinfo->reltoasttablespace when
> calling ArchiveEntry()?
Yes, doing this that way is cleaner. Here is a new version including
your fix. Thanks.
--
Julien
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[application/gzip] set_toast_tablespace_v0.17.patch.gz (13.4K, ../550D61D9.9060602@gmail.com/2-set_toast_tablespace_v0.17.patch.gz)
download
view thread (57+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: julmon@gmail.com, andreas@proxel.se, ash@commandprompt.com, alvherre@2ndquadrant.com, jaime@2ndquadrant.com, robertmhaas@gmail.com
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
In-Reply-To: <550D61D9.9060602@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox