Subject: Re: pageinspect: Hash index support
To: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
References: <e2ac6c58-b93f-9dd9-f4e6-d6d30add7fdf@redhat.com>
 <CAA4eK1JDXuOUsx-x0FzOJJGX6Xa4jOL80y62ScZLqdEOuGBXMA@mail.gmail.com>
 <CAE9k0PnA=CnkaBCYfkL9jMJ5yNm5nEad=Cx2x8ED8Yo2j8+pzA@mail.gmail.com>
 <4f9c865b-0f79-83a7-a540-1533706c24ee@redhat.com>
 <CAE9k0PkewVp0HzkaiztjiUma8tsZLMi+Gx==4Wszj3tR8A0acA@mail.gmail.com>
 <CAD__OugG-LRWN-dFpdwr62v9f4HWDRtAdwzHXVfNAU_fSR-pRw@mail.gmail.com>
 <CA+TgmoZUjrVy52TUU3b_Q5L6jcrt7w5R4qFwMXdeCuKQBmYWqQ@mail.gmail.com>
 <CAE9k0Pke046HKYfuJGcCtP77NyHrun7hBV-v20a0TW4CUg4H+A@mail.gmail.com>
 <CA+TgmoaTRh4B75CguW=pWLjJ=LLBBH-=Anz6pcPFn5jx_VQPQQ@mail.gmail.com>
 <CAE9k0Pnkx0mxAejDX6S6EBaNAgv=Fj9DoEx7B0vy=d6kmzcNzQ@mail.gmail.com>
 <CA+Tgmoa6cKSV26d_XMwqw2Hwh_hk5wZpuVJg18WTVQ-L6vr+Aw@mail.gmail.com>
 <408828d9-e1b1-16b0-63fe-f2aeea83bc5c@redhat.com>
 <b2c7d6f0-edc3-6fce-cbbe-82ca277e2f22@redhat.com>
 <17311.1486134714@sss.pgh.pa.us>
 <CA+Tgmob_0UZNbjr53LGuWs-XiezBo5P6ar=Wu2dvxvU=PPOg3A@mail.gmail.com>
 <095699f0-22f2-49fe-672b-b746f3219120@redhat.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>,
        Mithun Cy <mithun.cy@enterprisedb.com>,
        Amit Kapila
 <amit.kapila16@gmail.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        Jeff Janes <jeff.janes@gmail.com>,
        Alvaro Herrera
 <alvherre@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: JBoss, by Red Hat
Message-ID: <551edf28-6133-d714-aa07-e04b6848b7f5@redhat.com>
Date: Fri, 3 Feb 2017 11:49:09 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <095699f0-22f2-49fe-672b-b746f3219120@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 02/03/2017 11:41 AM, Jesper Pedersen wrote:
>>> contrib/pageinspect actually seems to lack *any* infrastructure
>>> for sharing functions across modules.  It's time to remedy that.
>>> I propose inventing "pageinspect.h" to hold commonly visible
>>> declarations, and moving get_page_from_raw() into rawpage.c,
>>> which seems like a reasonably natural home for it.  (Alternatively,
>>> we could invent a pageinspect.c file to hold utility functions,
>>> but that might be overkill.)
>>
>> No objections.
>>
>
> Attached is v1 of this w/ verify_hash_page() using get_page_from_raw().
>
> Sorry for all the problems.
>

Disregard, as Tom has committed a fix.

Best regards,
  Jesper


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers